Align participants sorting with Web #186
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
looks great in general. However, we need to test few things before merging, since there's some logic that's removed that might have an impact. @testableapple can also help.
| @@ -380,24 +364,6 @@ open class CallViewModel: ObservableObject { | |||
| /// - participant: the participant whose track visibility would be changed. | |||
| /// - isVisible: whether the track should be visible. | |||
| public func changeTrackVisibility(for participant: CallParticipant, isVisible: Bool) { | |||
| if !isVisible { | |||
There was a problem hiding this comment.
While some of this stuff might not be needed anymore, with the introduction of the visibility modifier, we need to test all cases. This code was here because of tracks being hidden when changing layouts. Did you test that everything works as expected?
There was a problem hiding this comment.
Tests so far haven't yield anything concerning but i'll run another round with this one and the comment above just to be sure.
There was a problem hiding this comment.
I had one case where one track never got enabled. Hard to tell if it was us or the SFU.
There was a problem hiding this comment.
That was related to this #191
ipavlidakis
force-pushed
the
feature/retain-ordering-when-speaker-changes
branch
4 times, most recently
from
006ecc7 to
b675e4f
Compare
There was a problem hiding this comment.
great work 👏 I did some tests, but would be good if @testableapple does some more.
- Resolve issues where participants swap places while on visible viewport
ipavlidakis
force-pushed
the
feature/retain-ordering-when-speaker-changes
branch
from
b675e4f to
de7056d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/582
🎯 Goal
Avoid moving video tracks when user properties change, especially when that user is currently visible.
📝 Summary
Based on React implementation here
☑️ Contributor Checklist