Fix ChatView disappearing when call events happening #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinmitrevski
approved these changes
Oct 10, 2023
| import SwiftUI | ||
| import StreamVideoSwiftUI | ||
|
|
||
| struct ChatModifier: ViewModifier { |
There was a problem hiding this comment.
I like this idea of having chat modifier. Maybe we could introduce chat extensions for video as reusable components in the future 👍
There was a problem hiding this comment.
Sounds a good idea and will make integration much easier for customers. I think we should have that in our roadmap
ipavlidakis
deleted the
fix/chat-popup-closing-when-any-call-event-occur
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/577
📝 Summary
ChatView was disappearing when call events where happening.
🛠 Implementation
The issue is that the ChatViewModel we rely on wasn't hold as StateObject somewhere, which causing the creation of multiple instances that were then affecting the ChatView presentation.
🧪 Manual Testing Notes
☑️ Contributor Checklist