[Fix]Deeplink handling #163
Conversation
+ OSLogDestination to allow us to see logs from release version + DeeplinkTests that ensure deeplink handling
| @@ -6,8 +6,7 @@ | |||
| <string>development</string> | |||
| <key>com.apple.developer.associated-domains</key> | |||
| <array> | |||
| <string>applinks:staging.getstream.io</string> | |||
There was a problem hiding this comment.
This isn't needed as the domain is the same and can be handled.
| @@ -229,7 +229,7 @@ extension AppEnvironment { | |||
| case .debug: | |||
| return [.staging, .pronto, .production] | |||
| case .test: | |||
| return [.staging] | |||
There was a problem hiding this comment.
Update test environment to be able to process all available deeplinks
|
|
||
| final class OSLogDestination: BaseLogDestination { | ||
|
|
||
| override func write(message: String) { |
There was a problem hiding this comment.
This allows us to see our logs from the AppStore versions using the Console.app
| @@ -140,12 +140,16 @@ struct DetailedCallingView: View { | |||
| self.callId = callId | |||
| viewModel.joinCall(callType: .default, callId: callId) | |||
| } | |||
| .onReceive(appState.$deeplinkInfo) { deeplinkInfo in | |||
There was a problem hiding this comment.
Added this one to align the DetailedCallingView with the SimpleView and allow us to perform the DeeplinkTests
DemoApp/Sources/Views/CallView/CallingView/DetailedCallingView.swift
Outdated
Show resolved
Hide resolved
|
|
||
| import XCTest | ||
|
|
||
| final class DeeplinkTests: StreamTestCase { |
There was a problem hiding this comment.
Awesome 🚀 When are these tests being run? Should we put them as part of the checks or in a test plan?
There was a problem hiding this comment.
They are part of the UI Tests so i believe they should be running as part of the Release. Not sure about the PR checks though. Maybe @testableapple can provide more insight to this one.
There was a problem hiding this comment.
It will be executed with the other tests
There was a problem hiding this comment.
Nicely done, @ipavlidakis!
Looks really great, I just have a couple of questions.
Issue
Resolves https://github.com/GetStream/ios-issues-tracking/issues/571
🎯 Goal
Ensure deeplinks are working consistently
📝 Summary
A few issues discovered:
🛠 Implementation
Implemented UITests that validate deeplink handling for
☑️ Contributor Checklist