Fix things

GetStream · Oct 17, 2023 · ee5bf93 · ee5bf93
1 parent 05da584
commit ee5bf93
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 12 deletions.
diff --git a/SwiftUIDemoAppUITests/Tests/DeeplinkTests.swift b/SwiftUIDemoAppUITests/Tests/DeeplinkTests.swift
@@ -45,7 +45,6 @@ final class DeeplinkTests: StreamTestCase {
         WHEN("user navigates to the app through deeplink") {
             Safari()
                 .open(MockDeeplink.production)
-                .alertHandler()
                 .tapOnOpenButton()
         }
         THEN("user joins the the specified call") {

diff --git a/TestTools/UITests/Safari.swift b/TestTools/UITests/Safari.swift
@@ -26,14 +26,18 @@ struct Safari {
     func open(_ url: URL) -> Self {
         safari.launch()
         _ = safari.wait(for: .runningForeground, timeout: 5)
-
-        // Type the deeplink and execute it
-        let firstLaunchContinueButton = safari.buttons["Continue"]
-        if firstLaunchContinueButton.exists {
-            firstLaunchContinueButton.tap()
-        }
+        if #available(iOS 16.4, *) {
+            safari.open(url)
+            return self
+        } else {
+            // Type the deeplink and execute it
+            let firstLaunchContinueButton = safari.buttons["Continue"]
+            if firstLaunchContinueButton.exists {
+                firstLaunchContinueButton.tap()
+            }
 
-        return go(to: url)
+            return go(to: url)
+        }
     }
 
     @discardableResult
@@ -49,14 +53,18 @@ struct Safari {
     }
 
     @discardableResult
-    func tapOnOpenButton(_ timeout: TimeInterval = 5) -> Self {
+    func tapOnOpenButton() -> Self {
         let openButton = safari.buttons.matching(NSPredicate(format: "label LIKE 'OPEN' OR label LIKE 'Open'")).firstMatch
-
+        let reloadButton = safari.buttons["ReloadButton"]
         var counter = 0
-        while !openButton.wait(timeout: timeout).exists || counter < 5 {
-            safari.buttons["ReloadButton"].tap()
+
+        while !openButton.exists && counter < 5 {
+            reloadButton.wait().tap()
+            reloadButton.wait()
+            alertHandler()
             counter += 1
         }
+        XCTAssertTrue(openButton.exists, "Open button does not exist")
 
         openButton.tap()
         return self