[Fix]Sorting comparators for fullscreen layout and PiP

GetStream · Dec 3, 2024 · bb1c1a6 · bb1c1a6
1 parent 2ee1c89
commit bb1c1a6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Sources/StreamVideo/Utils/Sorting.swift b/Sources/StreamVideo/Utils/Sorting.swift
@@ -17,13 +17,12 @@ public typealias StreamSortComparator<Value> = (Value, Value) -> ComparisonResul
 public let defaultComparators: [StreamSortComparator<CallParticipant>] = [
     pinned,
     screensharing,
-    ifInvisible(combineComparators([
+    combineComparators([
         dominantSpeaker,
         isSpeaking,
-        isSpeaking,
         publishingVideo,
         publishingAudio
-    ])),
+    ]),
     ifInvisible(userId)
 ]
 

diff --git a/StreamVideoTests/Utils/Sorting_Tests.swift b/StreamVideoTests/Utils/Sorting_Tests.swift
@@ -702,7 +702,8 @@ final class Sorting_Tests: XCTestCase {
         )
     }
 
-    func test_defaultComparators_someSpeakingWhileDominantSpeakerIsVisible_orderDoesNotChange() {
+    func test_defaultComparators_someSpeakingWhileDominantSpeakerIsVisible_orderSetsToShowDominanFirstAndTheOthersSortedBasedOnOtherCriteria(
+    ) {
         let combined = combineComparators(defaultComparators)
 
         assertSort(
@@ -733,7 +734,7 @@ final class Sorting_Tests: XCTestCase {
                 )
             ],
             comparator: combined,
-            expectedTransformer: { [$0[0], $0[1], $0[2], $0[3]] }
+            expectedTransformer: { [$0[3], $0[0], $0[1], $0[2]] }
         )
     }