Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(persistence): add support for polls and poll votes #2060

Open
wants to merge 58 commits into
base: master
Choose a base branch
from

Conversation

xsahil03x
Copy link
Member

This pull request includes several changes to the stream_chat package, focusing on adding support for polls and poll votes. The most important changes include adding new methods for handling polls and poll votes, updating data access objects (DAOs) to support these new entities, and integrating these changes throughout the codebase.

Poll and Poll Vote Support:

Data Access Objects (DAOs) Updates:

Integration with Chat Persistence:

Testing and Converters:

…at/polls-attachment-composer

# Conflicts:
#	packages/stream_chat/lib/src/core/models/poll.dart
#	packages/stream_chat/lib/src/core/models/poll.g.dart
#	packages/stream_chat/lib/src/core/models/poll_option.dart
#	packages/stream_chat/lib/src/core/models/poll_option.g.dart
#	packages/stream_chat/lib/src/core/models/poll_vote.dart
#	packages/stream_chat/lib/src/core/models/poll_vote.g.dart
#	packages/stream_chat/lib/src/event_type.dart
…eat/poll-persistence

# Conflicts:
#	packages/stream_chat_persistence/CHANGELOG.md
#	packages/stream_chat_persistence/pubspec.yaml
@xsahil03x xsahil03x marked this pull request as ready for review December 9, 2024 14:03
Base automatically changed from feat/poll-message-widget to master December 24, 2024 16:27
xsahil03x and others added 10 commits December 24, 2024 17:36
# Conflicts:
#	packages/stream_chat/lib/src/core/models/poll.dart
#	packages/stream_chat/lib/src/core/models/poll_vote.dart
#	packages/stream_chat/lib/src/db/chat_persistence_client.dart
#	packages/stream_chat_flutter/lib/src/message_input/attachment_picker/stream_attachment_picker.dart
#	packages/stream_chat_flutter/lib/src/poll/creator/poll_option_reorderable_list_view.dart
#	packages/stream_chat_flutter/lib/src/theme/stream_chat_theme.dart
#	packages/stream_chat_flutter/test/src/poll/creator/poll_option_reorderable_list_view_test.dart
#	packages/stream_chat_flutter/test/src/poll/creator/poll_question_text_field_test.dart
#	packages/stream_chat_flutter/test/src/poll/creator/stream_poll_creator_dialog_test.dart
#	packages/stream_chat_flutter/test/src/poll/interactor/poll_add_comment_dialog_test.dart
#	packages/stream_chat_flutter/test/src/poll/interactor/poll_footer_test.dart
#	packages/stream_chat_flutter/test/src/poll/interactor/poll_header_test.dart
#	packages/stream_chat_flutter/test/src/poll/interactor/poll_suggest_option_dialog_test.dart
#	packages/stream_chat_flutter/test/src/poll/interactor/stream_poll_interactor_test.dart
#	packages/stream_chat_flutter/test/src/poll/stream_poll_options_dialog_test.dart
#	packages/stream_chat_flutter/test/src/poll/stream_poll_results_dialog_test.dart
#	packages/stream_chat_flutter_core/test/stream_poll_controller_test.dart
#	packages/stream_chat_localizations/lib/src/stream_chat_localizations_it.dart
#	packages/stream_chat_persistence/CHANGELOG.md
#	packages/stream_chat_persistence/pubspec.yaml
@xsahil03x xsahil03x requested a review from deven98 December 24, 2024 17:49
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 90.50000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 60.81%. Comparing base (337074e) to head (875de8b).

Files with missing lines Patch % Lines
...ges/stream_chat/lib/src/core/models/poll_vote.dart 0.00% 10 Missing ⚠️
...tream_chat/lib/src/db/chat_persistence_client.dart 85.71% 7 Missing ⚠️
...ream_chat_persistence/lib/src/dao/message_dao.dart 50.00% 1 Missing ⚠️
...at_persistence/lib/src/dao/pinned_message_dao.dart 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2060      +/-   ##
==========================================
+ Coverage   60.59%   60.81%   +0.22%     
==========================================
  Files         356      361       +5     
  Lines       21846    22018     +172     
==========================================
+ Hits        13237    13391     +154     
- Misses       8609     8627      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsahil03x xsahil03x requested a review from kanat December 24, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants