fix: await remote even when instance is present in memory cache #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshedor
changed the title
mateominato
approved these changes
Jul 10, 2023
| * Apply standardized lints | ||
| * Respect `awaitRemote` policy for `OfflineFirstRepository#get` - fixes a bug where an instance in memory cache would early-return before hitting remote despite the requested `await` or `alwaysHydrate` policy |
There was a problem hiding this comment.
i feel like i can point to this for bugs we looked at years ago in GB register
Comment on lines
+187
to
+188
| // ignore: unawaited_futures | ||
| hydrate<TModel>(query: query, deserializeSqlite: !seedOnly); |
There was a problem hiding this comment.
do you prefer this lint ignore to wrapping in unawaited?
There was a problem hiding this comment.
Well...I genuinely don't know the difference. What would you favor?
There was a problem hiding this comment.
there isn't; it's stylistic. but i think unawaited brings the decision into code and out of comments which i generally like
There was a problem hiding this comment.
Ok yeah that's a great point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.