respond to config change for terminal suggestions (microsoft#235999)

* fix microsoft#235071 * tweak * fixes microsoft#235996 * tweak
GesuBackups · Dec 13, 2024 · db62636 · db62636
1 parent b911e7c
commit db62636
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminal.suggest.contribution.ts b/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminal.suggest.contribution.ts
@@ -61,6 +61,24 @@ class TerminalSuggestContribution extends DisposableStore implements ITerminalCo
 			this._pwshAddon?.dispose();
 		}));
 		this._terminalSuggestWidgetVisibleContextKey = TerminalContextKeys.suggestWidgetVisible.bindTo(this._contextKeyService);
+		this.add(this._configurationService.onDidChangeConfiguration(e => {
+			if (e.affectsConfiguration(TerminalSuggestSettingId.EnableExtensionCompletions) || e.affectsConfiguration(TerminalSuggestSettingId.Enabled)) {
+				const extensionCompletionsEnabled = this._configurationService.getValue<ITerminalSuggestConfiguration>(terminalSuggestConfigSection).enableExtensionCompletions;
+				const completionsEnabled = this._configurationService.getValue<ITerminalSuggestConfiguration>(terminalSuggestConfigSection).enabled;
+				if (!extensionCompletionsEnabled || !completionsEnabled) {
+					this._addon.clear();
+				}
+				if (!completionsEnabled) {
+					this._pwshAddon.clear();
+				}
+				const xtermRaw = this._ctx.instance.xterm?.raw;
+				if (!!xtermRaw && extensionCompletionsEnabled || completionsEnabled) {
+					if (xtermRaw) {
+						this._loadAddons(xtermRaw);
+					}
+				}
+			}
+		}));
 	}
 
 	xtermOpen(xterm: IXtermTerminal & { raw: RawXtermTerminal }): void {