BioHackathon24 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use left joins in Project mapping."
- no semicolon at end of source sql - need left joins if right side might be NULL
- left joins for dataset and image. - split into multiple mappings to ease debugging
- convert most joins to left joins
- add ome_marshal:Dataset and test query works correctly.
- Add test with a query using ome_marshal:Dataset
|
@joshmoore , @marimeireles, maybe one of you can give this a look and merge. |
|
What's the plan for the "hack24" directory long term? i.e. will those items be integrated elsewhere? |
|
@CFGrote: what happened here? I now no longer see the hack24/ code. |
|
yeah sorry for being impatient . I merged this one to be able to continue on other stuff. All mappings are now in ontop/, no separate directories for the various omero instances anymore. The hack24 mappings are preserved in ontop/hack24.obda. Hope that's ok. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (WIP) adds all developments from the biohackathon2024 into the main branch.
Mappings for the muenster .137 in hack24/
Mappings for the MPI ome instance in MPIEB/
added a test that checks class matching against another ontology via
owl:equivalentClassworks correctlysmall cleanups and typos.
Adding ontop artifacts for hackathon.
Update mapping and properties.
Update all in hack24
Update props.
untrack cataloge.
Ignore catalog file in hack24.
Fixing project mappings
Update mappings
Update mappings
Debug mappings.
Update ontology.
Update test
Fix indent.
Add query against the MPIEB OME KG
Adding mapping and ontology geared towards mpieb.