Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto of full screen management #1173

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Conversation

dtrucs
Copy link
Collaborator

@dtrucs dtrucs commented Jun 17, 2024

  • Don't wait for server hydration to load images (avoid cumulative layout shift)
  • Remove the react-easyfullscreen package
  • Create a dedicated hook to manage fullscreen
  • No more condition for managing IOS fullscreen (cf FullScreen API supported by Safari 16.4  #901)

@dtrucs dtrucs requested a review from a team June 17, 2024 13:42
@dtrucs dtrucs force-pushed the Refacto-of-Full-Screen-Management branch from 640e384 to f8f13ae Compare June 17, 2024 14:11
frontend/src/components/Modal/Modal.tsx Outdated Show resolved Hide resolved
frontend/src/components/Modal/Modal.tsx Outdated Show resolved Hide resolved
@dtrucs dtrucs requested a review from Bo-Duke June 20, 2024 07:36
@dtrucs dtrucs force-pushed the Refacto-of-Full-Screen-Management branch from bdacbd0 to f5522c9 Compare June 20, 2024 07:41
@dtrucs dtrucs merged commit fa9e7f4 into develop Jun 20, 2024
2 checks passed
@dtrucs dtrucs deleted the Refacto-of-Full-Screen-Management branch June 20, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants