Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'loadinfrastructure' condition adding to infra without 'eid-field' option #4329

Conversation

noelmartinon
Copy link
Contributor

If '--confition-field' is used with 'loadinfrastructure', add condition to infra even if option '--eid-field' is not used.
#4328

Copy link
Contributor

@Chatewgne Chatewgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing, could you please add a line at the top of docs/changelog.rst mentioning the fix and the issue number please ?

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (8abe56a) to head (0c5b553).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4329   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         267      267           
  Lines       20926    20928    +2     
=======================================
+ Hits        20594    20596    +2     
  Misses        332      332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Oct 14, 2024

Geotrek-admin    Run #10095

Run Properties:  status check passed Passed #10095  •  git commit e23380dbf6 ℹ️: Merge 0c5b55333cfe3d9a04f377ae671c5bfad4baf6a0 into 8abe56a98efe6310600c2ae2b85c...
Project Geotrek-admin
Run status status check passed Passed #10095
Run duration 02m 11s
Commit git commit e23380dbf6 ℹ️: Merge 0c5b55333cfe3d9a04f377ae671c5bfad4baf6a0 into 8abe56a98efe6310600c2ae2b85c...
Committer Noël Martinon
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22

@camillemonchicourt
Copy link
Member

La PR du changelog de cette modification a été mergée (#4329), mais pas celle-ci qui comprend la correction de la commande.

@Chatewgne Chatewgne merged commit 3499349 into GeotrekCE:master Oct 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants