Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GeotrekSiteParser and GeotrekCourseParser to Aggregator (refs #3569) #3926

Merged
merged 15 commits into from
Mar 13, 2024
Merged

Add GeotrekSiteParser and GeotrekCourseParser to Aggregator (refs #3569) #3926

merged 15 commits into from
Mar 13, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Feb 5, 2024 •
edited
Loading

Description

Related Issue

#3569

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@cypress Cypress
Copy link

cypress bot commented Feb 5, 2024 •
edited
Loading

Passing run #8303 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge f1fab97 into a411f84...
Project: Geotrek-admin Commit: 50d7f884c5 ℹ️
Status: Passed Duration: 02:22 💡
Started: Mar 12, 2024 4:38 PM Ended: Mar 12, 2024 4:41 PM

Review all test suite changes for PR #3926 ↗︎

@Chatewgne Chatewgne force-pushed the feat_add_aggregator_for_outdoor branch 9 times, most recently from 69c224a to 54f617d Compare February 9, 2024 17:35
@camillemonchicourt camillemonchicourt changed the title ✨ [FEAT] Add GeotrekSiteParser and tests (refs #3569) ✨ [FEAT] Add GeotrekOutdoorParser and tests (refs #3569) Feb 11, 2024
@Chatewgne Chatewgne force-pushed the feat_add_aggregator_for_outdoor branch 3 times, most recently from d75502d to 70f7ad5 Compare February 19, 2024 13:50
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (a411f84) to head (f1fab97).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3926      +/-   ##
==========================================
+ Coverage   98.36%   98.37%   +0.01%     
==========================================
  Files         295      296       +1     
  Lines       22396    22560     +164     
==========================================
+ Hits        22029    22193     +164     
  Misses        367      367

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chatewgne Chatewgne force-pushed the feat_add_aggregator_for_outdoor branch 2 times, most recently from 5837a7f to 59e41ab Compare February 22, 2024 10:05
@Chatewgne Chatewgne marked this pull request as ready for review February 22, 2024 10:05
@Chatewgne Chatewgne force-pushed the feat_add_aggregator_for_outdoor branch 2 times, most recently from 2959e02 to ba4cbfc Compare February 22, 2024 12:34
@Chatewgne Chatewgne changed the title ✨ [FEAT] Add GeotrekOutdoorParser and tests (refs #3569) ✨ [FEAT] Add GeotrekSiteParser and GeotrekCourseParser to Aggregator (refs #3569) Feb 22, 2024
@Chatewgne Chatewgne requested a review from juggler31 February 22, 2024 13:26
@Chatewgne Chatewgne force-pushed the feat_add_aggregator_for_outdoor branch 5 times, most recently from 4a814ea to 40ef8fa Compare February 28, 2024 09:13
@Chatewgne Chatewgne force-pushed the feat_add_aggregator_for_outdoor branch from 3015355 to 5f4f379 Compare March 1, 2024 14:33
@Chatewgne Chatewgne force-pushed the feat_add_aggregator_for_outdoor branch from 7c9f2ee to f0e038f Compare March 4, 2024 14:12
@babastienne babastienne mentioned this pull request Mar 8, 2024
Open
21 tasks
@babastienne babastienne requested a review from a team March 11, 2024 13:34
Chatewgne added 14 commits March 12, 2024 14:57
@Chatewgne
✨ [FEAT] Add GeotrekSiteParser and tests (refs #3569)
c5d3234
@Chatewgne
✨ [FEAT] Add fetching related categories and parent sites in GeotrekS…
b2e865b 
…iteParser (refs #3569)
@Chatewgne
🔥 [CLEAN] Clean GeotrekSiteParser test file (refs #3569)
f386730
@Chatewgne
✅ [TEST] Add test for GeotrekSiteParser attachments (refs #3569)
e3e2340
@Chatewgne
✨ [FEAT] Add GeotrekCourseParser and tests (refs #3569)
f08083d
@Chatewgne
✨ [FEAT] Handle category mappings in GeotrekOutdoorParser (refs #3569)
ae97901
@Chatewgne
✅ [TEST] Change OutdoorParser test language (refs #3569)
224121e
@Chatewgne
✅ [TEST] Add test for OutdoorParser wrong children (refs #3569)
d20c9d1
@Chatewgne
🐛 [BUG] Fix edge cases in GeotrekOutdoorParser (refs #3569)
04e5c01
@Chatewgne
✅ [TEST] Remove unused test files (refs #3569)
915fefa
@Chatewgne
💫 [IMPR] Fix objects deletions in OutdoorParser (refs #3569)
6e7d5bf
@Chatewgne
🐛 [BUG] Fix reference points parsing in GeotrekCourseParser (refs #3569)
1a181df
@Chatewgne
🐛 [BUG] Fix missing Ratings returned in APIv2 (refs #3569)
8edecb6
@Chatewgne
🐛 [BUG] Fix parser cannot delete some Sites (refs #3569)
c0ccb16
@Chatewgne Chatewgne force-pushed the feat_add_aggregator_for_outdoor branch from f0e038f to c0ccb16 Compare March 12, 2024 13:58
marcantoinedupre
marcantoinedupre requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@marcantoinedupre marcantoinedupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

geotrek/outdoor/parsers.py Outdated Show resolved Hide resolved
@Chatewgne Chatewgne merged commit 1db5598 into master Mar 13, 2024
16 checks passed
@Chatewgne Chatewgne deleted the feat_add_aggregator_for_outdoor branch March 13, 2024 12:32
@babastienne babastienne changed the title ✨ [FEAT] Add GeotrekSiteParser and GeotrekCourseParser to Aggregator (refs #3569) Add GeotrekSiteParser and GeotrekCourseParser to Aggregator (refs #3569) Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcantoinedupre marcantoinedupre marcantoinedupre requested changes

@juggler31 juggler31 juggler31 approved these changes

@submarcos submarcos submarcos approved these changes

Assignees
No one assigned
Labels
✨ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chatewgne @submarcos @marcantoinedupre @juggler31