Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Signage & Blade conditions translations + admin BladeCondition entry (#3847) #3903

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

juggler31
Copy link
Contributor

@juggler31 juggler31 commented Jan 24, 2024

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Jan 24, 2024

Passing run #7962 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge a58a9dc into 373865c...
Project: Geotrek-admin Commit: 09b03fde74 ℹ️
Status: Passed Duration: 02:04 💡
Started: Feb 12, 2024 10:43 AM Ended: Feb 12, 2024 10:45 AM

Review all test suite changes for PR #3903 ↗︎

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (373865c) 98.34% compared to head (a58a9dc) 98.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3903   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         294      294           
  Lines       22261    22262    +1     
=======================================
+ Hits        21893    21894    +1     
  Misses        368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juggler31 juggler31 force-pushed the trad_signage_conditions branch from e453284 to 89884a5 Compare January 24, 2024 14:01
@juggler31 juggler31 marked this pull request as draft January 24, 2024 14:02
@juggler31 juggler31 force-pushed the trad_signage_conditions branch from 89884a5 to 34b9d79 Compare January 24, 2024 16:23
@juggler31 juggler31 changed the title add signage & blade translations + add admin blade conditions entry 🐛 [FIX] Signage & Blade conditions translations + admin BladeCondition entry Jan 24, 2024
@juggler31 juggler31 force-pushed the trad_signage_conditions branch from 34b9d79 to af9b6d2 Compare January 24, 2024 16:27
@juggler31 juggler31 changed the title 🐛 [FIX] Signage & Blade conditions translations + admin BladeCondition entry 🐛 [FIX] Signage & Blade conditions translations + admin BladeCondition entry (#3847) Jan 24, 2024
@juggler31 juggler31 marked this pull request as ready for review January 24, 2024 16:29
@juggler31 juggler31 requested a review from a team January 24, 2024 16:30
@juggler31 juggler31 force-pushed the trad_signage_conditions branch 2 times, most recently from 1ebecd1 to 76033aa Compare January 29, 2024 13:18
@juggler31 juggler31 force-pushed the trad_signage_conditions branch from 76033aa to 4899ff7 Compare February 8, 2024 15:00
@juggler31 juggler31 requested a review from submarcos February 9, 2024 09:14
@juggler31 juggler31 force-pushed the trad_signage_conditions branch from 4899ff7 to 5de2980 Compare February 12, 2024 09:45
@juggler31 juggler31 force-pushed the trad_signage_conditions branch from 5de2980 to a58a9dc Compare February 12, 2024 10:27
@juggler31 juggler31 merged commit b514749 into master Feb 12, 2024
15 checks passed
@juggler31 juggler31 deleted the trad_signage_conditions branch February 12, 2024 13:14
@babastienne babastienne changed the title 🐛 [FIX] Signage & Blade conditions translations + admin BladeCondition entry (#3847) [FIX] Signage & Blade conditions translations + admin BladeCondition entry (#3847) Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

# 23 - Possibilité de sélectionner plusieurs états sur les signalétiques et lames
3 participants