-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for sensitivity module (refs #3876) #3877
Improve documentation for sensitivity module (refs #3876) #3877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your much needed contribution to the documentation ! 🙏
Few comments :
- For three files (
authors.po
changelog.po
andinstall.po
), I'm not sure why you put them in the PR as I don't see any modification ? Also it is a good practice to add the parameter--no-location
when you run themakemessages
command in order to avoid having all the line number modifications. - I added some context / few minor corrections. It it suits you don't hesitate to commit them and regenerate the translations accordingly.
- I'm in doubt about the organisation of the files. Why did you move this documentation in the "user manual" section ? It seems to me that information about API and import data is quite technical, don't you think ? And I have the feeling that the information is separated in two pages but still quite the same as there will be information about the procedure to import data on one page and the details about the data format on another. (maybe @camillemonchicourt can give us his pov ?)
- I think if we talk about importing data, we should mention at least the possiblity to import all data directly from network. I added a suggestion in this regard.
Yes it should grouped in one section, certainly Import, and it is not to go into User manual, but rather in technical parts for administrators. |
Co-authored-by: babastienne <[email protected]>
Co-authored-by: babastienne <[email protected]>
Co-authored-by: babastienne <[email protected]>
Co-authored-by: babastienne <[email protected]>
Co-authored-by: babastienne <[email protected]>
Co-authored-by: babastienne <[email protected]>
Co-authored-by: babastienne <[email protected]>
Passing run #9093 ↗︎
Details:
Review all test suite changes for PR #3877 ↗︎ |
Documentation revue et restructurée:
|
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
Co-authored-by: Camille Monchicourt <[email protected]>
@babastienne, @bruhnild, is there any new missing requirements for that PR or could it be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good
Thanks for your contribution @lpofredc, this pull request has been merged. The official documentation will be updated with your changes when we'll release the next version of Geotrek. |
Description
The purpose of this pull request is to integrate sensitive module notices into GeoTrek documentation.
Related Issue
#3876
Checklist
I have commented my code, particularly in hard-to-understand areasI have added tests that prove my fix is effective or that my feature works.New and existing unit tests pass locally with my changes