Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[📝 Documentation] - Improve documentation about suricate workflow (refs #3870) #3873

Closed
wants to merge 2 commits into from
Closed

[📝 Documentation] - Improve documentation about suricate workflow (refs #3870) #3873

wants to merge 2 commits into from

Conversation

bruhnild
Copy link
Contributor

@bruhnild bruhnild commented Jan 3, 2024 •
edited
Loading

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@bruhnild bruhnild requested a review from Chatewgne January 3, 2024 09:58
@bruhnild bruhnild self-assigned this Jan 3, 2024
@bruhnild bruhnild mentioned this pull request Jan 3, 2024
Closed
2 tasks
Chatewgne
Chatewgne requested changes Jan 3, 2024
View reviewed changes
docs/install/advanced-configuration.rst
@@ -1580,8 +1675,7 @@ A (nearly?) exhaustive list of attributes available for display and export as co
]
COLUMNS_LISTS["intervention_export"] = [
"name",
"begin_date",
"end_date",
"date",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase branch please

@bruhnild bruhnild closed this Jan 3, 2024
@babastienne babastienne deleted the mfu-improve-documentation-suricate branch January 3, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chatewgne Chatewgne Chatewgne requested changes

Assignees

@bruhnild bruhnild

Labels
📝 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruhnild @Chatewgne