Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conditions on signage (refs #3847) #3826

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Add conditions on signage (refs #3847) #3826

merged 3 commits into from
Dec 14, 2023

Conversation

juggler31
Copy link
Contributor

@juggler31 juggler31 commented Nov 7, 2023 •
edited by Chatewgne
Loading

Description

Related Issue

#3847
https://github.com/orgs/GeotrekCE/projects/6?pane=issue&itemId=41639115

Checklist

@juggler31 juggler31 marked this pull request as draft November 7, 2023 10:21
@cypress Cypress
Copy link

cypress bot commented Nov 7, 2023 •
edited
Loading

Passing run #7643 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 72431a3 into 1b5c0be...
Project: Geotrek-admin Commit: 9b6f5ed6dc ℹ️
Status: Passed Duration: 02:03 💡
Started: Dec 12, 2023 1:11 PM Ended: Dec 12, 2023 1:13 PM

Review all test suite changes for PR #3826 ↗︎

@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46ad1bc) 98.34% compared to head (72431a3) 98.35%.
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3826   +/-   ##
=======================================
  Coverage   98.34%   98.35%           
=======================================
  Files         292      292           
  Lines       21932    22004   +72     
=======================================
+ Hits        21569    21641   +72     
  Misses        363      363

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juggler31 juggler31 force-pushed the feat_signage_condition branch 7 times, most recently from 4d3a974 to fdf6de1 Compare November 17, 2023 14:52
@juggler31 juggler31 force-pushed the feat_signage_condition branch 2 times, most recently from 2c5abf9 to 54fcc53 Compare November 20, 2023 13:01
@juggler31 juggler31 changed the title Draft: signage cd30 Add conditions on signage Nov 20, 2023
@juggler31 juggler31 force-pushed the feat_signage_condition branch from 54fcc53 to c66cefc Compare November 20, 2023 16:35
@juggler31 juggler31 requested a review from Chatewgne November 21, 2023 08:59
@juggler31 juggler31 force-pushed the feat_signage_condition branch 2 times, most recently from 23b5809 to bda7bcc Compare November 23, 2023 08:40
Chatewgne
Chatewgne requested changes Nov 23, 2023
View reviewed changes
geotrek/api/v2/urls.py Outdated Show resolved Hide resolved
geotrek/signage/parsers.py Outdated Show resolved Hide resolved
geotrek/signage/serializers.py Show resolved Hide resolved
geotrek/signage/tests/test_command_signage.py Show resolved Hide resolved
geotrek/signage/views.py Show resolved Hide resolved
@juggler31 juggler31 force-pushed the feat_signage_condition branch from bda7bcc to 68fc530 Compare November 24, 2023 16:15
@Chatewgne Chatewgne marked this pull request as ready for review November 29, 2023 10:58
@juggler31 juggler31 force-pushed the feat_signage_condition branch from 68fc530 to f5b6f34 Compare December 5, 2023 16:15
@juggler31 juggler31 requested a review from Chatewgne December 6, 2023 10:35
submarcos
submarcos reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@submarcos submarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add changelog please

@juggler31 juggler31 force-pushed the feat_signage_condition branch from f5b6f34 to fab01c5 Compare December 12, 2023 10:02
@Chatewgne Chatewgne changed the title Add conditions on signage Add conditions on signage (refs #3826) Dec 12, 2023
@Chatewgne Chatewgne changed the title Add conditions on signage (refs #3826) Add conditions on signage (refs #3847) Dec 12, 2023
@juggler31 juggler31 force-pushed the feat_signage_condition branch from fab01c5 to 72431a3 Compare December 12, 2023 13:00
@juggler31 juggler31 merged commit 749a2b1 into master Dec 14, 2023
15 checks passed
@juggler31 juggler31 deleted the feat_signage_condition branch December 14, 2023 13:56
@juggler31 juggler31 linked an issue Dec 19, 2023 that may be closed by this pull request
# 23 - Possibilité de sélectionner plusieurs états sur les signalétiques et lames #3847
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcantoinedupre marcantoinedupre marcantoinedupre left review comments

@submarcos submarcos submarcos left review comments

@Chatewgne Chatewgne Chatewgne approved these changes

Assignees
No one assigned
Labels
💫 Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

# 23 - Possibilité de sélectionner plusieurs états sur les signalétiques et lames
4 participants
@juggler31 @submarcos @marcantoinedupre @Chatewgne