Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language bug in several detail pages (#3577) #3808

Closed
wants to merge 1 commit into from

Conversation

njourdane
Copy link
Contributor

Description

This PR allows to change language directly in several detail pages. The related issue reports the bug in Sensitivity, but a similar bug also appears in signage, outdoor sites, outdoor courses, infrastructure, POI, touristic content, and touristic events, so the PR also fix those.

Related Issue

#3577

Checklist

@cypress
Copy link

cypress bot commented Oct 23, 2023

Passing run #7462 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 4b22f20 into ed76b17...
Project: Geotrek-admin Commit: 0e9bf0415d ℹ️
Status: Passed Duration: 03:24 💡
Started: Oct 23, 2023 6:45 PM Ended: Oct 23, 2023 6:49 PM

Review all test suite changes for PR #3808 ↗︎

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (ed76b17) to head (4b22f20).
Report is 1063 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3808   +/-   ##
=======================================
  Coverage   98.33%   98.34%           
=======================================
  Files         292      292           
  Lines       21817    21870   +53     
=======================================
+ Hits        21454    21507   +53     
  Misses        363      363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njourdane njourdane force-pushed the bug_lang_detail_pages branch from 698c287 to 4b22f20 Compare October 23, 2023 18:30
@babastienne babastienne changed the title 🐛 [Bug fixes] fix language bug in several detail pages (#3577) Fix language bug in several detail pages (#3577) Nov 14, 2023
@submarcos submarcos closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants