Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to identify and merge some paths #3607 #3648

Merged
merged 10 commits into from
Jan 11, 2024
Merged

Add command to identify and merge some paths #3607 #3648

merged 10 commits into from
Jan 11, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Jul 21, 2023 •
edited
Loading

@Chatewgne Chatewgne force-pushed the feat_merge_path_command branch from a2364cf to b8adb6b Compare July 21, 2023 15:43
@cypress
Copy link

cypress bot commented Jul 21, 2023 •
edited
Loading

Passing run #7754 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 5e61dc0 into b7575d8...
Project: Geotrek-admin Commit: 0ea5518292 ℹ️
Status: Passed Duration: 02:05 💡
Started: Jan 11, 2024 1:11 PM Ended: Jan 11, 2024 1:13 PM

Review all test suite changes for PR #3648 ↗︎

@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7575d8) 98.35% compared to head (5e61dc0) 98.35%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #3648    +/-   ##
========================================
  Coverage   98.35%   98.35%            
========================================
  Files         292      293     +1     
  Lines       22067    22174   +107     
========================================
+ Hits        21703    21810   +107     
  Misses        364      364

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chatewgne Chatewgne force-pushed the feat_merge_path_command branch from afb1575 to 6525e44 Compare July 25, 2023 15:05
@Chatewgne Chatewgne marked this pull request as ready for review July 25, 2023 15:05
@Chatewgne Chatewgne force-pushed the feat_merge_path_command branch from 6525e44 to 320f462 Compare July 25, 2023 15:11
@Chatewgne Chatewgne requested review from a team and Huquette July 25, 2023 15:13
@babastienne
Copy link
Member

🙏 ❤️

babastienne
babastienne requested changes Jul 26, 2023
View reviewed changes
Copy link
Member

@babastienne babastienne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some explanations in the "exploitation command" section of the documentation please ?

@Chatewgne
Copy link
Contributor Author

Can you add some explanations in the "exploitation command" section of the documentation please ?

image

@babastienne
Copy link
Member

Can you add some explanations in the "exploitation command" section of the documentation please ?

image

Great, thanks @Chatewgne. Could you put the warning in a "danger" section in order for it to but more visible ? Like this :

image

@Chatewgne
Copy link
Contributor Author

Great, thanks @Chatewgne. Could you put the warning in a "danger" section in order for it to but more visible ? Like this
image

babastienne
babastienne approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@babastienne babastienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Already used on multiple instances and it works fine !

@babastienne babastienne changed the title Add command to identify and merge some paths Add command to identify and merge some paths #3607 Sep 5, 2023
@Chatewgne Chatewgne force-pushed the feat_merge_path_command branch 2 times, most recently from a661a25 to 1a890bc Compare October 6, 2023 12:20
@babastienne
Copy link
Member

babastienne commented Jan 11, 2024 •
edited
Loading

I used this command already and recently again on two instances without identifying any issue. Could this PR be merged soon or is it missing something ?

@Chatewgne
Copy link
Contributor Author

I used this command already and recently again on two instances without identifying any issue. Could this PR be merged soon or is it missing something ?

Glad to hear it worked fine, I'll rebase and merge it 🤗

@Chatewgne Chatewgne force-pushed the feat_merge_path_command branch from 1a890bc to 5e61dc0 Compare January 11, 2024 13:00
@Chatewgne Chatewgne merged commit 2341bfd into master Jan 11, 2024
15 checks passed
@Chatewgne Chatewgne deleted the feat_merge_path_command branch January 11, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LePetitTim LePetitTim LePetitTim left review comments

@babastienne babastienne babastienne approved these changes

@Huquette Huquette Awaiting requested review from Huquette

Assignees
No one assigned
Labels
✨ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chatewgne @babastienne @LePetitTim