Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WMTS CITE compliance fixes #1342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WMTS CITE compliance fixes #1342

wants to merge 1 commit into from

Conversation

aaime
Copy link
Member

@aaime aaime commented Jan 4, 2025

No description provided.

@aaime aaime mentioned this pull request Jan 4, 2025
Open
11 tasks
@aaime aaime force-pushed the wmts_cite_compliance branch from ee75f08 to 3ae40fe Compare January 4, 2025 18:28
@jodygarnett
Copy link
Contributor

Azure storage was having trouble:

OnlineAzureBlobStoreIntegrationIT.testPutWithListener » Storage Failed to setup Azure connection and container

@aaime
Copy link
Member Author

aaime commented Jan 9, 2025

That test has been failing systematically, it's a credentials issue. I've pinged @groldan about it a few times. I'd say we disable the test for the time being, and rely on the emulator tests instead (Azurite).

@aaime
Copy link
Member Author

aaime commented Jan 11, 2025

Here we go:
#1343

groldan
groldan approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@groldan groldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only issue I found is one of these three new methods is not being called at all so maybe just remove it. Can't remember right now which one of them though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groldan groldan groldan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaime @jodygarnett @groldan