Allow building with QA on Java 17+ #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `mvn ... -Dqa` with Java 17/21 breaks errorprone. Fixed with: * Update errorProne.version:2.18.0 -> 2.24.1 * Add `geowebcache/.mvn/jvm.config` with the required `--add-exports` for the `maven-compiler-plugin` as explained at https://errorprone.info/docs/installation#jdk-16.
Fixes spotbugs when run with Java 21, otherwise getting ``` Execution spotbugs of goal com.github.spotbugs:spotbugs-maven-plugin:4.7.3.4:spotbugs failed: java.lang.UnsupportedOperationException: The Security Manager is deprecated and will be removed in a future release ```
groldan
force-pushed
the
allow_qa_build_with_java_17plus
branch
from
9ad063d to
5fb1ad3
Compare
aaime
reviewed
Jan 8, 2024
Comment on lines
269
to
271
| proxyUrl = new URL(getGwcConfig().getProxyUrl()); | ||
| proxyUrl = new URI(getGwcConfig().getProxyUrl()).toURL(); | ||
| log.fine("Using proxy " + proxyUrl.getHost() + ":" + proxyUrl.getPort()); |
There was a problem hiding this comment.
If I guess correctly, this change is related to the deprecation or "new URL(string)" in Java 21.
Rather than repeating this pattern over and over, along with the exception rethrowing, could we have a dedicated support method, similar (but not same) to what we have URLs.fileToURL() in GeoTools?
There was a problem hiding this comment.
You got it. See org.geowebcache.util.URLs
groldan
force-pushed
the
allow_qa_build_with_java_17plus
branch
from
5fb1ad3 to
94d2d95
Compare
groldan
force-pushed
the
allow_qa_build_with_java_17plus
branch
from
94d2d95 to
001bba7
Compare
* `Thread.getId()` is deprecated. Since it's only used for reporting
errors, use `Thread.getName()` instead
* `new URL(String)` is deprecated. Use `new URI(String).toURL()`
instead, throwing `MalformedURLException` to preserve the old
behavior in methods that throw `IOException`. This is centralized in
the new utility class/method `org.geowebcache.util.URLs.of(String
url)`
* `ExecutorService` implements `AutoCloseable` in Java 21, add
`@SuppressWarnings("PMD.CloseResource")` in the test classes that use it
* Add `@SuppressFBWarnings` for new rules
groldan
force-pushed
the
allow_qa_build_with_java_17plus
branch
from
001bba7 to
b5ea3b7
Compare
|
Looks good to me, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
mvn ... -Dqawith Java 17/21 breaks errorprone, as in:Fixed with:
2.18.0->2.24.1geowebcache/.mvn/jvm.configwith the required--add-exportsfor themaven-compiler-pluginas explained at https://errorprone.info/docs/installation#jdk-16.Fixes to build with Java 21:
Thread.getId()is deprecated. Since it's only used for reporting errors, useThread.getName()insteadnew URL(String)is deprecated. Usenew URI(String).toURL()instead, throwingMalformedURLExceptionto preserve the old behavior in methods that throwIOException. This is centralized in the new utility class/methodorg.geowebcache.util.URLs.of(String url)ExecutorServiceimplementsAutoCloseablein Java 21, add@SuppressWarnings("PMD.CloseResource")in the test classes that use it@SuppressFBWarningsfor new rules related to POJO fields unset/null, when they're assigned using reflection by XStream