[Fixes #12170] unable to set advanced contact roles in metadata editor

[mwallschlaeger]

ref #12170 , #10367 , #10290

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• This PR passes the QA checks: black geonode && flake8 geonode
• Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
• Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[giohappy]

tests are failing do to this error @mwallschlaeger:

ERROR: test_resource_form_is_valid_extra_metadata (geonode.geoapps.tests.GeoAppTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/src/geonode/geonode/base/widgets.py", line 36, in value_from_datadict
    ret_list = data.getlist(name)
AttributeError: 'dict' object has no attribute 'getlist'

During handling of the above exception, another exception occurred:

[mwallschlaeger]

@giohappy I will check this and fix the issue

[giohappy]

@mwallschlaeger change the PR to Ready for review when ready. At the moment I still see tests failing after your latest commits.

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.04%. Comparing base (3d6ab6e) to head (df4a4d7).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #12171   +/-   ##
=======================================
  Coverage   64.04%   64.04%           
=======================================
  Files         870      870           
  Lines       52178    52178           
  Branches     6483     6484    +1     
=======================================
+ Hits        33418    33420    +2     
+ Misses      17259    17258    -1     
+ Partials     1501     1500    -1     

[mwallschlaeger]

@giohappy its ready review now

[giohappy]

@mwallschlaeger could you also fix the editor for documents?

[mwallschlaeger]

@giohappy i will take care of this tomorrow

[giohappy]

@mwallschlaeger this fix should be backported to 4.2.x too. Can you please take care of this?

[mwallschlaeger]

@giohappy yes i can cherry-pick the commits to 4.2.x beginning of next week

[giohappy]

@mwallschlaeger if it's a matter of cherry-picking I can do it, but I suspect it's more then that, since 4.2.x uses Django 3

[mwallschlaeger]

@giohappy i will take a look at it. no worries