Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2.x #11863

Closed
wants to merge 17 commits into from
Closed

4.2.x #11863

wants to merge 17 commits into from

Conversation

cesarbenjamindotnet
Copy link

This is my contributions updated to 4.2.x that i begun on 4.1.x to update dependency constraint to django 3.2.x, there is a lot of changes, i know that @mattiagiupponi had work on it too and can be code conflicts, so, please review it, mine have a lot of changes for compatibility and so on, i was manually testing a lot until i was able to run it successful

This is about #11821 and #11722 open issues.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • [-] Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • [-] There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

github-actions bot and others added 16 commits October 26, 2023 16:45
(cherry picked from commit ec457bc)

Co-authored-by: mattiagiupponi <[email protected]>
* thesaurus topics should only return its own keys (#11644)

* [Fixes #11652] Facets: wrong count on multiple tkeywords filtering (#11655)

* [Fixes #11652] Facets: wrong count on multiple tkeywords filtering - tkeywords

* [Fixes #11652] Facets: wrong count on multiple tkeywords filtering - category

* [Fixes #11652] Facets: wrong count on multiple tkeywords filtering - region

* [Fixes #11652] Facets: wrong count on multiple tkeywords filtering - keywords

---------

Co-authored-by: Emanuele Tajariol <[email protected]>
…#11677)

* [Fixes #11447] Bad role name in creating GeoFence rules

* [Fixes #11668] Bad ordering of GeoFence rules

---------

Co-authored-by: Giovanni Allegri <[email protected]>
(cherry picked from commit e7b53a5)

Co-authored-by: Emanuele Tajariol <[email protected]>
* Update default avatar image

* Change to default avatar

* Reduce avatar dim

(cherry picked from commit e705eaf)

Co-authored-by: mattiagiupponi <[email protected]>
… (#11694)

Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: Giovanni Allegri <[email protected]>
(cherry picked from commit bc45eaf)

Co-authored-by: Alessio Fabiani <[email protected]>
…c assignment o… (#11695) (#11696)

* Implement the option to register users without automatic assignment of contributor role #11651

* Fixes #11651: configuration rename

* Fixes #11651: configuration rename

(cherry picked from commit 980e4d2)

Co-authored-by: mattiagiupponi <[email protected]>
…11712)

* Add env-var to override the readonly mode

* Fix flake8 issue

* Add test coverage

* Add test coverage

* Add test coverage

* Fix broken test

(cherry picked from commit a655d8d)

Co-authored-by: mattiagiupponi <[email protected]>
…11718)

* [Fixes #11716] extension for remote document is not saved

* [Fixes #11716] fix formatting

(cherry picked from commit 7cac111)

Co-authored-by: mattiagiupponi <[email protected]>
# Conflicts:
#	requirements.txt
#	scripts/docker/nginx/Dockerfile
Copy link

cla-bot bot commented Jan 21, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: cesar.benjamin.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cesarbenjamindotnet
Copy link
Author

Sorry, i made the PR in wrong branch :(

Copy link

cla-bot bot commented Jan 22, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: cesar.benjamin.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants