Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11579] Use autocomplete API for editing linked resources #11584

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

etj
Copy link
Contributor

@etj etj commented Oct 12, 2023

#11579 Use autocomplete API for editing linked resources

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj added the master label Oct 12, 2023
@etj etj self-assigned this Oct 12, 2023
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 12, 2023
@etj etj force-pushed the 11579_related_autocomplete branch from e103d49 to a75d52f Compare October 12, 2023 10:10
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #11584 (e6a8ef8) into master (fbee36c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11584      +/-   ##
==========================================
+ Coverage   62.13%   62.16%   +0.02%     
==========================================
  Files         871      871              
  Lines       51988    52020      +32     
  Branches     6495     6495              
==========================================
+ Hits        32303    32338      +35     
+ Misses      18136    18133       -3     
  Partials     1549     1549              

Copy link
Contributor

@mattiagiupponi mattiagiupponi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add also a couple of tests for the other resources? I see them only for datasets

geonode/base/views.py Outdated Show resolved Hide resolved
geonode/base/forms.py Outdated Show resolved Hide resolved
@etj etj force-pushed the 11579_related_autocomplete branch from a75d52f to e2c62f2 Compare October 12, 2023 11:59
@etj etj force-pushed the 11579_related_autocomplete branch from e2c62f2 to e6a8ef8 Compare October 12, 2023 12:05
@etj etj requested a review from mattiagiupponi October 12, 2023 14:03
@etj etj dismissed mattiagiupponi’s stale review October 12, 2023 14:27

Test implemented

@mattiagiupponi mattiagiupponi merged commit ac26caa into master Oct 12, 2023
9 checks passed
@mattiagiupponi mattiagiupponi deleted the 11579_related_autocomplete branch October 12, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants