Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and target frameworks and fix build warnings #27

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

mus65
Copy link
Contributor

@mus65 mus65 commented Oct 27, 2024

Starting with .NET 9, NuGet Audit will transitively scan for CVEs, so consuming applications will get a warning about System.Text.Json:

warning NU1903: Package 'System.Text.Json' 6.0.1 has a known high severity vulnerability, GHSA-8g4q-xg66-9fp4

#24 already optimized this to only affect .NET Framework (but it's still not released).

This updates all dependencies (except Nunit 4 which has a lot of breaking changes) and cleans up some build warnings:

  • removed netstandard2.0 from test projects. This doesn't make sense because you can't run tests against netstandard2.0 (LangVersion also isn't needed anymore then)
  • removed EOL net7.0 target and added net8.0
  • removed Microsoft.CodeAnalysis.NetAnalyzersbecause it's part of the SDK since .NET 5

@xfischer xfischer self-requested a review October 27, 2024 09:54
@xfischer
Copy link
Member

xfischer commented Oct 27, 2024

Hi ! Thanks a lot for your contribution. Will review and ask a review from @janusw (I have to add it here also) who did so much lately for the main repo.
Please allow a couple of hours as I don't have access to my laptop now.

Copy link
Member

@janusw janusw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong with this, except that probably the GHA hooks need to be updated to deal with .NET 8 as well. Maybe someone can approve the workflows to run, so that we can see them fail? 😆

@mus65
Copy link
Contributor Author

mus65 commented Oct 27, 2024

Good point, I also updated the GitHub actions and dropped the EOL .NET versions from CI.

@janusw
Copy link
Member

janusw commented Oct 27, 2024

Good point, I also updated the GitHub actions and dropped the EOL .NET versions from CI.

👍 Now we only need someone to approve the workflows so that they will actually run. @xfischer Can you do that?

@janusw
Copy link
Member

janusw commented Oct 28, 2024

Alright, so the build job runs fine, but the benchmarking job fails. That one also needs to be adjusted:
https://github.com/GeoJSON-Net/GeoJSON.Text/blob/main/.github/workflows/continous-benchmark.yml

@xfischer
Copy link
Member

@janusw @mus65 thanks to both of you.
@janusw I've added you as a maintainer

@mus65
Copy link
Contributor Author

mus65 commented Oct 28, 2024

Benchmarks should hopefully be fixed now, but I guess the workflow needs another approval. 😄 I removed net6.0 from the benchmark project since .NET 6 is EOL next month anyway.

@janusw
Copy link
Member

janusw commented Oct 28, 2024

Benchmarks should hopefully be fixed now, but I guess the workflow needs another approval. 😄

Since I'm a maintainer, I can do that now. 💪 (thanks, @xfischer !)

@janusw
Copy link
Member

janusw commented Oct 31, 2024

Alright, all the CI jobs run fine by now and the PR was approved already, so I'll just merge it ...

@janusw janusw merged commit 2f669b3 into GeoJSON-Net:main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants