System 2449/fix gamepad #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the first commit should not be in this PR ? Or maybe this PR should not target |
|
yes it cames from this PR |
pgivel
requested changes
Apr 8, 2024
jparez
reviewed
Apr 8, 2024
src/plugins/GamepadManager.js
Outdated
| this.currentGamepads[localIndex] = {remoteIndex: remoteIndex, buttons: []}; | ||
| const gamepad = this.getRawGamepad(remoteIndex); | ||
| this.currentGamepads[localIndex] = {remoteIndex: remoteIndex, | ||
| buttons: [gamepad.buttons.length], |
There was a problem hiding this comment.
In case of getRawGamepad doesn't return a gamepad and wathever you return from getRawGamepad ( undefined or null) you wil get an uncaught error here : Uncaught TypeError: gamepad is null
pgivel
requested changes
Apr 8, 2024
src/plugins/GamepadManager.js
Outdated
Comment on lines
373
to
375
| this.currentGamepads[hostIndex] = {remoteIndex: hostIndex, | ||
| buttons: [gamepad.buttons.length], | ||
| axes: [gamepad.axes.length]}; |
There was a problem hiding this comment.
Suggested change
| this.currentGamepads[hostIndex] = {remoteIndex: hostIndex, | |
| buttons: [gamepad.buttons.length], | |
| axes: [gamepad.axes.length]}; | |
| this.currentGamepads[hostIndex] = { | |
| remoteIndex: hostIndex, | |
| buttons: [gamepad.buttons.length], | |
| axes: [gamepad.axes.length] | |
| }; |
I think it would be more readable like this. But maybe simply use the yarn validate --fix command to fix the code style everywhere.
cmajed
force-pushed
the
SYSTEM-2449/fix_gamepad
branch
from
f40cd2d to
0f1448b
Compare
pgivel
approved these changes
Apr 10, 2024
cmajed
force-pushed
the
SYSTEM-2449/fix_gamepad
branch
from
8a4ce29 to
0611484
Compare
cmajed
force-pushed
the
SYSTEM-2449/fix_gamepad
branch
from
0611484 to
bbc9dae
Compare
- handle gamepad pugged/unplugged
- catch and handle confirmation
- send correct vinput gamepad redis message
- Handle axis changes
- Rework catch and dispatch event to dispatch it only when axes changed
- Add vendor id and product id to the plugg in command
cmajed
force-pushed
the
SYSTEM-2449/fix_gamepad
branch
from
bbc9dae to
2f6c615
Compare
jparez
approved these changes
Apr 12, 2024
pgivel
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework Gamepad and Gamepad Management to fix:
- handle gamepad pugged/unplugged
- catch and handle confirmation
- send correct vinput gamepad redis message
- Handle axis changes
- Rework catch and dispatch event to dispatch it only when axes changed
- Add vendor id and product id to the plugg in command
Type of change
Checklist