Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAYER-2] bind keypress envent on root div instead of window object #64

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[PLAYER-2] bind keypress envent on root div instead of window object #64

merged 1 commit into from
Mar 19, 2024

Conversation

jparez
Copy link
Contributor

@jparez jparez commented Mar 18, 2024

Description

Fix bug when typing charater outside of player events were send to the instance

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I've checked my modifications for any breaking changes.

@jparez jparez added the bug Something isn't working label Mar 18, 2024
@jparez jparez requested a review from pgivel March 18, 2024 16:04
@jparez jparez force-pushed the dev/player-2-fix-issue-with-kepress-bind-on-window branch from f6788e3 to 9fb1638 Compare March 18, 2024 16:05
pgivel
pgivel approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@pgivel pgivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can test on shadow player that it doesn't break stuff if you wish, although as we discussed over slack I don't think it will since the shadow player overrides this plugin.

@jparez jparez merged commit de9049a into integration/player-1-fix-issue-with-kepress-bind-on-window Mar 19, 2024
1 check passed
@jparez jparez deleted the dev/player-2-fix-issue-with-kepress-bind-on-window branch March 19, 2024 15:49
@jparez jparez mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgivel pgivel pgivel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jparez @pgivel