Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the example to use the latest apis for fetching recipes and accessing instances. #111

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Update the example to use the latest apis for fetching recipes and accessing instances. #111

merged 3 commits into from
Oct 3, 2024

Conversation

caarmen
Copy link
Contributor

@caarmen caarmen commented Sep 26, 2024 •
edited
Loading

Description

☝🏻 This is currently based on top of #112. It should be rebased on main after #112 is merged.

Accessing instances

See the documentation for POST /v1/instances/access-token: https://developer.genymotion.com/saas/#tag/Instances-v1/operation/accessToken

It has an instance_uuid request payload field.

Text clarification

Now that an instance uuid is required to connect to a SaaS instance, clarify that:

  • Connection via instance uuid is only for Genymotion SaaS.
  • Connection via webrtc address is only for Genymotion Device Image.

Tests

Tested accessing a device:

Platform By launching from the example By connecting to already launched device
SaaS image image
Device Image N/A Help 😅

Fetching recipes

Use the GET /v3/recipes/ route to retrieve recipes.

See the documentation: https://developer.genymotion.com/saas/#tag/Recipes-v3/operation/listRecipesV3

Tests

Note that the v3 recipes route returns recipes in a flat list.

Before After
Screenshot from 2024-09-26 14-55-44 image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
    • Only tested on Edge :)
  • I have made corresponding changes to the documentation (README.md).
    • Don't think it's needed?
  • I've checked my modifications for any breaking changes.
    • Not sure what can break, it's an example.

@caarmen caarmen changed the title Update the example to provide the instance uuid when fetching a JWT token. Update the example to use the latest apis for fetching recipes and accessing instances. Sep 26, 2024
@caarmen caarmen force-pushed the dev/update-example-to-fetch-jwt-token-for-specific-instance branch 2 times, most recently from e8ad1c6 to d22c2ba Compare September 26, 2024 12:32
@caarmen caarmen changed the base branch from main to dev/fix-invalid-token-recipe-selection September 26, 2024 12:32
@caarmen caarmen force-pushed the dev/fix-invalid-token-recipe-selection branch from 4ee98c0 to 3c696e1 Compare September 26, 2024 14:11
@caarmen caarmen force-pushed the dev/update-example-to-fetch-jwt-token-for-specific-instance branch 2 times, most recently from bdf4d6c to c2b5e5e Compare September 26, 2024 15:38
Base automatically changed from dev/fix-invalid-token-recipe-selection to main September 27, 2024 13:05
@caarmen caarmen force-pushed the dev/update-example-to-fetch-jwt-token-for-specific-instance branch from c2b5e5e to 5a20d87 Compare September 27, 2024 13:05
@caarmen
Copy link
Contributor Author

caarmen commented Sep 27, 2024

Rebased on main to get changes from:

@caarmen caarmen marked this pull request as ready for review September 30, 2024 09:31
@caarmen caarmen requested review from jparez and pgivel September 30, 2024 09:31
@qbi-geny qbi-geny mentioned this pull request Sep 30, 2024
Merged
7 tasks
caarmen added 3 commits October 1, 2024 10:36
@caarmen
Example: Update the example to provide the instance uuid when fetchin…
0366eab 
…g a JWT token.

See the documentation for `POST /v1/instances/access-token`: https://developer.genymotion.com/saas/#tag/Instances-v1/operation/accessToken

It has an `instance_uuid` request payload field.
@caarmen
Example: Update the text for connecting to a websocket address directly.
980e11a 
Indicate that the instance uuid is for Genymotion SaaS, and the webrtc address is for Genymotion Device Image.
@caarmen
Example: Use the GET /v3/recipes/ route to retrieve recipes.
03e4be1 
See the documentation: https://developer.genymotion.com/saas/#tag/Recipes-v3/operation/listRecipesV3
@caarmen caarmen force-pushed the dev/update-example-to-fetch-jwt-token-for-specific-instance branch from 5a20d87 to 03e4be1 Compare October 1, 2024 08:37
@caarmen
Copy link
Contributor Author

caarmen commented Oct 1, 2024

Rebased on main to get changes from:

@jparez jparez merged commit 4d8bc97 into main Oct 3, 2024
1 check passed
@jparez jparez deleted the dev/update-example-to-fetch-jwt-token-for-specific-instance branch October 3, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparez jparez jparez approved these changes

@pgivel pgivel Awaiting requested review from pgivel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caarmen @jparez