feat: implement onCameraReady event on Windows (react-native-camera#3324

) * add onCameraReady event to InitializeAsync * changed null to nullptr * treat onCameraReady as a native event * register onCameraReady event constant Co-authored-by: Burton Rodman <[email protected]> Co-authored-by: Ethan <[email protected]>
GenomeUS · Aug 24, 2021 · 7b897b0 · 7b897b0
1 parent 6e33553
commit 7b897b0
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/src/RNCamera.js b/src/RNCamera.js
@@ -848,7 +848,7 @@ export default class Camera extends React.Component<PropsType, StateType> {
             style={StyleSheet.absoluteFill}
             ref={this._setReference}
             onMountError={this._onMountError}
-            onCameraReady={this._onCameraReady}
+            onCameraReady={this._onObjectDetected(this._onCameraReady)}
             onAudioInterrupted={this._onAudioInterrupted}
             onAudioConnected={this._onAudioConnected}
             onGoogleVisionBarcodesDetected={this._onObjectDetected(

diff --git a/windows/ReactNativeCameraCPP/ReactCameraConstants.h b/windows/ReactNativeCameraCPP/ReactCameraConstants.h
@@ -8,6 +8,7 @@
 #include "JSValue.h"
 
 #define BarcodeReadEvent L"onBarCodeRead"
+#define CameraReadyEvent L"onCameraReady"
 
 namespace winrt::ReactNativeCameraCPP {
 class ReactCameraConstants {

diff --git a/windows/ReactNativeCameraCPP/ReactCameraView.cpp b/windows/ReactNativeCameraCPP/ReactCameraView.cpp
@@ -714,6 +714,12 @@ IAsyncAction ReactCameraView::InitializeAsync() {
           });
 
       m_isInitialized = true;
+
+      auto control = this->get_strong().try_as<winrt::FrameworkElement>();
+      if (m_reactContext && control) {
+        m_reactContext.DispatchEvent(control, CameraReadyEvent, nullptr);
+      }
+
     }
   } catch (winrt::hresult_error const &) {
     m_isInitialized = false;

diff --git a/windows/ReactNativeCameraCPP/ReactCameraViewManager.cpp b/windows/ReactNativeCameraCPP/ReactCameraViewManager.cpp
@@ -89,6 +89,11 @@ ConstantProviderDelegate ReactCameraViewManager::ExportedCustomDirectEventTypeCo
     constantWriter.WriteObjectBegin();
     WriteProperty(constantWriter, L"registrationName", BarcodeReadEvent);
     constantWriter.WriteObjectEnd();
+
+    constantWriter.WritePropertyName(CameraReadyEvent);
+    constantWriter.WriteObjectBegin();
+    WriteProperty(constantWriter, L"registrationName", CameraReadyEvent);
+    constantWriter.WriteObjectEnd();
   };
 }