Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FileLoader library to thirdparty project #32

Closed
wants to merge 1 commit into from
Closed

Add FileLoader library to thirdparty project #32

wants to merge 1 commit into from

Conversation

scorpioluck20
Copy link
Contributor

  • Add MNNLoader to CMake build

@scorpioluck20 scorpioluck20 self-assigned this May 30, 2023
@scorpioluck20 scorpioluck20 linked an issue May 30, 2023 that may be closed by this pull request
Integrate IPFS loading from ipfs-lite-cpp library to load File formats for MNN #14
Open
@scorpioluck20
Copy link
Contributor Author

Linux, Window build passed.

2023-05-30T17:44:56.8423833Z   Performing install step for 'MNNLoader'
2023-05-30T17:44:56.8487974Z   Completed 'MNNLoader'

General Window build failed by other library.
iOS and Android build failed. But not come from the change.
MacOSX build failed due to know issue.
We can ask CI Team working for iOS, Android and MacOSX failed or at least we can merge develop-release branch to this branch and merge back to develop branch.

The example program is good example for any integrate or include MNNLoader library.
Safe to merge this PR.
BRs,
TN

@scorpioluck20 scorpioluck20 mentioned this pull request May 30, 2023
Open
Super-Genius
Super-Genius requested changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@Super-Genius Super-Genius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url for GeniusVentures repos should be in this format, so if we are on gitlab, etc it will pull from relative directories. See other .gitmodule entries.

../MNNLoader.git

@scorpioluck20
Copy link
Contributor Author

url for GeniusVentures repos should be in this format, so if we are on gitlab, etc it will pull from relative directories. See other .gitmodule entries.

../MNNLoader.git

Updated.

@scorpioluck20 scorpioluck20 force-pushed the 14-loading-mnn-format branch 6 times, most recently from eaa58fd to 1ac4f4b Compare June 12, 2023 16:18
@scorpioluck20
Copy link
Contributor Author

Compile success.

[ 85%] Completed 'FileLoader'

@scorpioluck20 scorpioluck20 force-pushed the 14-loading-mnn-format branch 2 times, most recently from 1005919 to 5bb58f7 Compare June 13, 2023 04:25
@scorpioluck20
Add FileLoader library to thirdparty project
49faf98 
  - Add FileLoader to CMake build
@scorpioluck20 scorpioluck20 changed the title Add MNNLoader library to thirdparty project Add FileLoader library to thirdparty project Jun 14, 2023
@scorpioluck20
Copy link
Contributor Author

Window and Linux OS compile success.
Another build failed due to another problem.
This PR is okay for merge.
@Super-Genius

@EduMenges EduMenges deleted the 14-loading-mnn-format branch May 23, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Super-Genius Super-Genius Awaiting requested review from Super-Genius

Assignees

@Super-Genius Super-Genius

@scorpioluck20 scorpioluck20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate IPFS loading from ipfs-lite-cpp library to load File formats for MNN
2 participants
@scorpioluck20 @Super-Genius