Dev fix tests #26
Closed
Dev fix tests #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
henriqueaklein
commented
Jul 19, 2023
henriqueaklein
commented
- Changed one byte of the block hash so that the vote was not evaluated as a duplicate.
- Made the header encoding test pass. It didn't because there was no case and the GetHeader didn't ran.
- Reviewed Coding standard and set clang format accordingly (let me know if there's something non compliant to the coding standard.
Super-Genius
approved these changes
Jul 19, 2023
|
Closes #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.