style: Removed blank lines and added [[nodiscard]]

.clang-tidy

@@ -24,6 +24,7 @@ Checks: >
   -google-build-using-namespace,
   -google-explicit-constructor,
   -google-readability-namespace-comments,
+  -google-readability-todo,
 
   hicpp-multiway-paths-covered,
 

src/authorship/block_builder.hpp

@@ -1,4 +1,3 @@
-
 #ifndef SUPERGENIUS_SRC_AUTHORSHIP_BLOCK_BUILDER_HPP
 #define SUPERGENIUS_SRC_AUTHORSHIP_BLOCK_BUILDER_HPP
 
@@ -25,7 +24,7 @@ namespace sgns::authorship {
     /**
      * Create a block from extrinsics and header
      */
-    virtual outcome::result<primitives::Block> bake() const = 0;
+    [[nodiscard]] virtual outcome::result<primitives::Block> bake() const = 0;
   };
 
 }  // namespace sgns::authorship

src/authorship/block_builder_factory.hpp

@@ -1,13 +1,8 @@
-
 #ifndef SUPERGENIUS_SRC_AUTHORSHIP_BLOCK_BUILDER_FACTORY_HPP
 #define SUPERGENIUS_SRC_AUTHORSHIP_BLOCK_BUILDER_FACTORY_HPP
 
-#include <vector>
-
 #include "authorship/block_builder.hpp"
 #include "primitives/block_id.hpp"
-#include "runtime/block_builder.hpp"
-#include "runtime/core.hpp"
 #include "integration/IComponent.hpp"
 
 namespace sgns::authorship {
@@ -24,10 +19,8 @@ namespace sgns::authorship {
      * Prepares BlockBuilder for creating block on top of parent block and using
      * provided digests. Also initialises the block created in BlockBuilder
      */
-    virtual outcome::result<std::unique_ptr<BlockBuilder>> create(
-        const primitives::BlockId &parent_id,
-        primitives::Digest inherent_digest) const = 0;
-
+    [[nodiscard]] virtual outcome::result<std::unique_ptr<BlockBuilder>> create(
+        const primitives::BlockId &parent_id, primitives::Digest inherent_digest ) const = 0;
   };
 
 }  // namespace sgns::authorship

src/authorship/impl/block_builder_error.cpp

@@ -1,4 +1,3 @@
-
 #include "authorship/impl/block_builder_error.hpp"
 
 OUTCOME_CPP_DEFINE_CATEGORY_3(sgns::authorship, BlockBuilderError, e) {

src/authorship/impl/block_builder_factory_impl.cpp

@@ -1,4 +1,3 @@
-
 #include "authorship/impl/block_builder_factory_impl.hpp"
 
 #include "authorship/impl/block_builder_impl.hpp"

src/authorship/impl/block_builder_factory_impl.hpp

@@ -1,4 +1,3 @@
-
 #ifndef SUPERGENIUS_SRC_AUTHORSHIP_IMPL_BLOCK_BUILDER_FACTORY_IMPL_HPP
 #define SUPERGENIUS_SRC_AUTHORSHIP_IMPL_BLOCK_BUILDER_FACTORY_IMPL_HPP
 
@@ -18,10 +17,9 @@ namespace sgns::authorship {
         //std::shared_ptr<runtime::BlockBuilder> r_block_builder,
         std::shared_ptr<blockchain::BlockHeaderRepository> header_backend);
 
-    outcome::result<std::unique_ptr<BlockBuilder>> create(
-        const sgns::primitives::BlockId &parent_id,
-        primitives::Digest inherent_digest) const override;
-
+    [[nodiscard]] outcome::result<std::unique_ptr<BlockBuilder>> create(
+        const sgns::primitives::BlockId &parent_id, primitives::Digest inherent_digest ) const override;
+
     std::string GetName() override
     {
       return "BlockBuilderFactoryImpl";

src/authorship/impl/block_builder_impl.hpp

@@ -1,13 +1,9 @@
-
 #ifndef SUPERGENIUS_SRC_AUTHORSHIP_IMPL_BLOCK_BUILDER_IMPL_HPP
 #define SUPERGENIUS_SRC_AUTHORSHIP_IMPL_BLOCK_BUILDER_IMPL_HPP
 
 #include "authorship/block_builder.hpp"
 
 #include "base/logger.hpp"
-#include "primitives/block_id.hpp"
-#include "runtime/block_builder.hpp"
-#include "runtime/core.hpp"
 
 namespace sgns::authorship {
 
@@ -21,9 +17,9 @@ namespace sgns::authorship {
     outcome::result<void> pushExtrinsic(
         const primitives::Extrinsic &extrinsic) override;
 
-    outcome::result<primitives::Block> bake() const override;
+    [[nodiscard]] outcome::result<primitives::Block> bake() const override;
 
-   private:
+private:
     primitives::BlockHeader block_header_;
     //std::shared_ptr<runtime::BlockBuilder> r_block_builder_;
     base::Logger logger_;

src/authorship/impl/proposer_impl.cpp

@@ -1,4 +1,3 @@
-
 #include "authorship/impl/proposer_impl.hpp"
 
 namespace sgns::authorship {

src/authorship/impl/proposer_impl.hpp

@@ -1,12 +1,10 @@
-
 #ifndef SUPERGENIUS_SRC_AUTHORSHIP_IMPL_AITHORING_IMPL_HPP
 #define SUPERGENIUS_SRC_AUTHORSHIP_IMPL_AITHORING_IMPL_HPP
 
 #include "authorship/proposer.hpp"
 
 #include "authorship/block_builder_factory.hpp"
 #include "base/logger.hpp"
-#include "runtime/block_builder.hpp"
 #include "transaction_pool/transaction_pool.hpp"
 
 namespace sgns::authorship {

src/authorship/proposer.hpp

@@ -1,9 +1,6 @@
-
-
 #ifndef SUPERGENIUS_SRC_AUTHORSHIP_PROPOSER_TEST_HPP
 #define SUPERGENIUS_SRC_AUTHORSHIP_PROPOSER_TEST_HPP
 
-#include "clock/clock.hpp"
 #include "primitives/block.hpp"
 #include "primitives/block_id.hpp"
 #include "primitives/digest.hpp"
@@ -17,19 +14,18 @@ namespace sgns::authorship {
    */
   class Proposer : public IComponent {
    public:
-    virtual ~Proposer() = default;
+       ~Proposer() override = default;
 
-    /**
+       /**
      * Creates block from provided parameters
      * @param parent_block_id hash or number of parent
      * @param inherent_data additional data on block from unsigned extrinsics
      * @param inherent_digests - chain-specific block auxilary data
      * @return proposed block or error
      */
-    virtual outcome::result<primitives::Block> propose(
-        const primitives::BlockId &parent_block_id,
-        const primitives::InherentData &inherent_data,
-        const primitives::Digest &inherent_digest) = 0;
+       virtual outcome::result<primitives::Block> propose( const primitives::BlockId      &parent_block_id,
+                                                           const primitives::InherentData &inherent_data,
+                                                           const primitives::Digest       &inherent_digest ) = 0;
   };
 
 }  // namespace sgns::authorship

src/base/blob.cpp

@@ -1,5 +1,3 @@
-
-
 #include "base/blob.hpp"
 
 OUTCOME_CPP_DEFINE_CATEGORY_3(sgns::base, BlobError, e) {

src/base/blob.hpp

@@ -1,5 +1,3 @@
-
-
 #ifndef SUPERGENIUS_BLOB_HPP
 #define SUPERGENIUS_BLOB_HPP
 
@@ -55,30 +53,33 @@ namespace sgns::base {
     /**
      * Converts current blob to std::string
      */
-    std::string toString() const noexcept {
-      return std::string{this->begin(), this->end()};
+    [[nodiscard]] std::string toString() const noexcept
+    {
+        return std::string{ this->begin(), this->end() };
     }
 
     /**
      * Converts current blob to a readable std::string
      */
-    std::string toReadableString() const noexcept {
-      std::string out_str;
-      char        temp_buf[3];
-      for ( auto it = this->begin(); it != this->end(); ++it )
-      {
-          snprintf( temp_buf, sizeof( temp_buf ), "%02x", *it );
-          out_str.append( temp_buf, sizeof( temp_buf ) - 1 );
-      }
-      return out_str;
+    [[nodiscard]] std::string toReadableString() const noexcept
+    {
+        std::string out_str;
+        char        temp_buf[3];
+        for ( auto it = this->begin(); it != this->end(); ++it )
+        {
+            snprintf( temp_buf, sizeof( temp_buf ), "%02x", *it );
+            out_str.append( temp_buf, sizeof( temp_buf ) - 1 );
+        }
+        return out_str;
     }
 
     /**
      * Converts current blob to hex string.
      */
-    std::string toHex() const noexcept {
-      // return hex_lower({this->begin(), this->end()});
-      return hex_lower(gsl::make_span(*this));
+    [[nodiscard]] std::string toHex() const noexcept
+    {
+        // return hex_lower({this->begin(), this->end()});
+        return hex_lower( gsl::make_span( *this ) );
     }
 
     /**

src/base/buffer.cpp

@@ -1,5 +1,3 @@
-
-
 #include "base/buffer.hpp"
 #include "base/hexutil.hpp"
 #include <iostream>
@@ -36,8 +34,9 @@ namespace sgns::base {
     return hex_lower(data_);
   }
 
-  const std::string_view Buffer::toString() const {
-    return std::string_view(reinterpret_cast<const char*>(data_.data()), data_.size()); // NOLINT
+  std::string_view Buffer::toString() const
+  {
+      return { reinterpret_cast<const char *>( data_.data() ), data_.size() };
   }
 
   bool Buffer::empty() const {

src/base/buffer.hpp

@@ -1,5 +1,3 @@
-
-
 #ifndef SUPERGENIUS_BUFFER_HPP
 #define SUPERGENIUS_BUFFER_HPP
 
@@ -110,29 +108,29 @@ namespace sgns::base {
     /**
      * @brief Iterator, which points to last of this buffer.
      */
-    const_reverse_iterator rbegin() const;
+    [[nodiscard]] const_reverse_iterator rbegin() const;
 
     /**
      * @brief Iterator, which points to the element previous to first in this
      * buffer.
      */
-    const_reverse_iterator rend() const;
+    [[nodiscard]] const_reverse_iterator rend() const;
 
     /**
      * @brief Iterator, which points to begin of this buffer.
      */
-    const_iterator begin() const;
+    [[nodiscard]] const_iterator begin() const;
 
     /**
      * @brief Iterator, which points to the element next to the last in this
      * buffer.
      */
-    const_iterator end() const;
+    [[nodiscard]] const_iterator end() const;
 
     /**
      * @brief Getter for size of this buffer.
      */
-    size_t size() const;
+    [[nodiscard]] size_t size() const;
 
     /**
      * @brief Put a 8-bit {@param n} in this buffer.
@@ -239,9 +237,9 @@ namespace sgns::base {
      * @note Does not ensure correct encoding
      * @return string
      */
-     const std::string_view toString() const;
+    std::string_view toString() const;
 
-   private:
+private:
     std::vector<uint8_t> data_;
 
     template <typename T>

src/base/buffer_back_insert_iterator.hpp

@@ -1,4 +1,3 @@
-
 #include "base/buffer.hpp"
 
 using sgns::base::Buffer;

src/base/hexutil.cpp

@@ -1,5 +1,3 @@
-
-
 #include "base/hexutil.hpp"
 
 #include <boost/algorithm/hex.hpp>

src/base/logger.cpp

@@ -1,5 +1,3 @@
-
-
 #include "base/logger.hpp"
 
 #include <spdlog/sinks/stdout_color_sinks.h>

src/base/logger.hpp

@@ -1,5 +1,3 @@
-
-
 #ifndef SUPERGENIUS_LOGGER_HPP
 #define SUPERGENIUS_LOGGER_HPP
 

src/base/mp_utils.cpp

@@ -1,5 +1,3 @@
-
-
 #include "base/mp_utils.hpp"
 
 #include <gsl/gsl_util>

src/base/mp_utils.hpp

@@ -1,5 +1,3 @@
-
-
 #ifndef SUPERGENIUS_SRC_CRYPTO_MP_UTILS_HPP
 #define SUPERGENIUS_SRC_CRYPTO_MP_UTILS_HPP
 

src/base/outcome_throw.hpp

@@ -1,5 +1,3 @@
-
-
 #ifndef SUPERGENIUS_SRC_COMMON_OUTCOME_THROW_HPP
 #define SUPERGENIUS_SRC_COMMON_OUTCOME_THROW_HPP
 

src/base/type_traits.hpp

@@ -1,4 +1,3 @@
-
 #ifndef SUPERGENIUS_TYPE_TRAITS
 #define SUPERGENIUS_TYPE_TRAITS
 

src/base/unused.hpp

@@ -1,4 +1,3 @@
-
 #ifndef SUPERGENIUS_UNUSED
 #define SUPERGENIUS_UNUSED
 

src/base/visitor.hpp

@@ -1,5 +1,3 @@
-
-
 #ifndef SUPERGENIUS_VISITOR_HPP
 #define SUPERGENIUS_VISITOR_HPP
 

src/base/wrapper.hpp

@@ -1,9 +1,6 @@
-
-
 #ifndef SUPERGENIUS_SRC_COMMON_WRAPPER_HPP
 #define SUPERGENIUS_SRC_COMMON_WRAPPER_HPP
 
-#include <memory>
 #include <type_traits>
 
 #include <boost/operators.hpp>