fix: rocksdb closes in destruction

GeniusVentures · May 10, 2024 · 1945adf · 1945adf
1 parent df82209
commit 1945adf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/storage/rocksdb/rocksdb.cpp b/src/storage/rocksdb/rocksdb.cpp
@@ -15,6 +15,11 @@ namespace sgns::storage
 {
   using BlockBasedTableOptions = ::ROCKSDB_NAMESPACE::BlockBasedTableOptions;
 
+  rocksdb::~rocksdb()
+  {
+      db_->Close();
+  }
+
   outcome::result<std::shared_ptr<rocksdb>> rocksdb::create(
       std::string_view path, Options options) 
   {

diff --git a/src/storage/rocksdb/rocksdb.hpp b/src/storage/rocksdb/rocksdb.hpp
@@ -33,7 +33,7 @@ namespace sgns::storage
     using Slice = ::ROCKSDB_NAMESPACE::Slice;
     using QueryResult = std::map<Buffer, Buffer>;
 
-    ~rocksdb() override = default;
+    ~rocksdb() override;
 
     /**
      * @brief Factory method to create an instance of rocksdb class.