Update libxml2 from 2.10.4 to 2.12.6 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobleuber
force-pushed
the
dobleuber/gen-2620
branch
from
b4ac081
to
a9722f0
Compare
hfsaito
requested changes
Mar 25, 2024
There was a problem hiding this comment.
We should remove all github actions or left them untouched
Did you take a look at the change made in the original repo?
sparklemotion#3153
Seems updating the dependency version is not the only thing needed
hfsaito
requested changes
Mar 25, 2024
ext/nokogiri/xml_reader.c
Outdated
Comment on lines
726
to
727
| } else { | ||
| rb_iv_set(self, "@encoding", NOKOGIRI_STR_NEW2("UTF-8")); |
There was a problem hiding this comment.
If you check the original change, this is not done inside this function
And the fix seems to be for a feature that is not present in this old version
Suggested change
| } else { | |
| rb_iv_set(self, "@encoding", NOKOGIRI_STR_NEW2("UTF-8")); |
hfsaito
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Have you included adequate test coverage?
Does this change affect the behavior of either the C or the Java implementations?