Skip to content

Commit

Permalink
Implement support for Genie cdn config
Browse files Browse the repository at this point in the history
  • Loading branch information
@essenciary
essenciary committed Feb 20, 2024
1 parent 26104da commit d9d0e59
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "GenieFramework"
uuid = "a59fdf5c-6bf0-4f5d-949c-a137c9e2f353"
authors = ["Adrian Salceanu <[email protected]> and contributors"]
version = "2.0.0"
version = "2.1.0"

[deps]
GarishPrint = "b0ab02a7-8576-43f7-aa76-eaa7c3897c54"
Expand All @@ -17,7 +17,7 @@ StippleUI = "a3c5d34a-b254-4859-a8fa-b86abb7e84a3"

[compat]
GarishPrint = "0.5"
Genie = "5.23.8"
Genie = "5.25.0"
GenieAutoReload = "2.2.3"
GenieDevTools = "2.8.4"
GeniePackageManager = "1.1.0"
Expand Down
6 changes: 3 additions & 3 deletions src/GenieFramework.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ if Genie.Configuration.isdev()
@reexport using GeniePackageManager
end

# Address conflicts - this is disgusting but necessary
# Address conflicts - this is ugly but necessary
# TODO: Refactor layout exports in next breaking release (v1)
# Both Stipple and StippleUI export layout
const q__layout = StippleUI.Layouts.layout
Expand Down Expand Up @@ -70,9 +70,9 @@ macro genietools()
end
end

if Genie.Configuration.isprod()
if Genie.Configuration.isprod() && Genie.config.cdn_enabled
try
Genie.Assets.assets_config!([Genie, Stipple, StippleUI, StipplePlotly], host = "https://cdn.statically.io/gh/GenieFramework")
Genie.Assets.assets_config!([Genie, Stipple, StippleUI, StipplePlotly], host = Genie.config.cdn_url)
catch ex
@error ex
end
Expand Down

2 comments on commit d9d0e59

@essenciary
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/101327

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v2.1.0 -m "<description of version>" d9d0e592163714bd10b4c1d56eb2c073d4d41f08
git push origin v2.1.0

Please sign in to comment.