Skip to content

Bump to ruff 0.10.0 and fix violations #3850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Bump to ruff 0.10.0 and fix violations #3850

merged 2 commits into from
Mar 13, 2025

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Mar 13, 2025

Description of proposed changes

Bumps ruff from 0.9.6 to 0.10.0.

Blog post for release is at https://astral.sh/blog/ruff-v0.10.0. This PR fixes errors with split-static-string (SIM905)

Fixes #3849 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 13, 2025
@weiji14 weiji14 self-assigned this Mar 13, 2025
@@ -27,7 +27,7 @@ dependencies:
# Dev dependencies (style checks)
- codespell
- pre-commit
- ruff>=0.9.6
- ruff>=0.10.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff 0.10.0 isn't available on conda-forge yet, wait for PR at https://github.com/conda-forge/ruff-feedstock/pulls before merging.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda-forge/ruff-feedstock#260 is merged now 🚀

@seisman seisman added this to the 0.15.0 milestone Mar 13, 2025
@seisman seisman marked this pull request as ready for review March 13, 2025 22:52
@seisman seisman merged commit 6388644 into main Mar 13, 2025
23 of 25 checks passed
@seisman seisman deleted the ruff/0.10.0 branch March 13, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants