Remove unnecessary np.atleast_1d calls from Figure.text and Session.virtualfile_in #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
This comment was marked as off-topic.
This comment was marked as off-topic.
michaelgrund
approved these changes
Oct 9, 2024
michaelgrund
added
final review call
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
As explained in #3497, calling
np.atleast_1dexplicitly is no longer necessary after we adopted thenumpy.ascontiguousarrayfunction in PR #3492.This PR removes the
np.atleast_1dcalls fromFigure.textandSession.virtualfile_in.After this PR,
np.atleast_1dis only used inFigure.mecabecause pandas needs 1-D arrays, e.g.,pygmt/pygmt/src/meca.py
Line 422 in 130d0cb