Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Implement virtualfile_from_image #3468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP: Implement virtualfile_from_image #3468
Changes from all commits
331f9aa
8c63ae6
5cc4cc7
7828153
149d2ae
ce2d0f2
232f8bd
8711928
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 95 in pygmt/clib/conversion.py
pygmt/clib/conversion.py#L95
Check warning on line 1692 in pygmt/clib/session.py
pygmt/clib/session.py#L1691-L1692
Check warning on line 1701 in pygmt/clib/session.py
pygmt/clib/session.py#L1700-L1701
Check warning on line 1705 in pygmt/clib/session.py
pygmt/clib/session.py#L1703-L1705
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seisman, can you check if I'm passing the
dim
arguments correctly tocreate_data
? Have looked at your notes added in #3532, and at https://docs.generic-mapping-tools.org/6.5/devdocs/api.html#create-empty-resources that it should be a tuple of 1) number of columns, 2) number of rows, 3) number of layers(bands?), and 4) data type of matrix (UCHAR?). But still getting a segfault ontest_grdcut_image_dataarray
.Check warning on line 1717 in pygmt/clib/session.py
pygmt/clib/session.py#L1714-L1717