clib: Change the parameter order and set output_type to pandas in virtualfile_to_dataset #3124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ualfile_to_dataset
seisman
added
maintenance
weiji14
changed the title
weiji14
reviewed
Mar 19, 2024
Comment on lines
1763
to
1764
| column_names | ||
| The column names for the :class:`pandas.DataFrame` output. |
There was a problem hiding this comment.
If the proof of concept at #3117 works, these lines will need to be updated (after we add some logic to use the header column names in this virtualfile_to_dataset method)
weiji14
approved these changes
Mar 19, 2024
Co-authored-by: Wei Ji <[email protected]>
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
For some module wrappers like
which,output_typemakes no sense because the a "file" or "numpy" output is useless. When refactoring these module wrappers, we have to usewhich doesn't look good.
This PR move the
vfnameparameter before theoutput_typeparameter and setoutput_type's default to"pandas", so that we can use a much shorter versionPutting
vfnameas the first parameter makes more sense becausevfnameis always a required parameter.Patches #3083.