Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for single quotation and double quotation marks ('"‘’“”) #3105

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 13, 2024

A working example:

import pygmt

label = "A'‘’\"“”"
fig = pygmt.Figure()
fig.basemap(region=[0, 10, 0, 10], projection="X4c/4c", frame=True)
fig.text(text=label, position="CM", font="20p", fill="230")
fig.show()

The output:

map

Fixes #3104.

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_text_nonascii.png

Image diff(s)

Added images

Modified images

Path Old New
test_text_nonascii.png

Report last updated at commit cc4b376

@seisman seisman marked this pull request as draft March 13, 2024 13:11
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer needs review This PR has higher priority and needs review. and removed final review call This PR requires final review and approval from a second reviewer labels Mar 13, 2024
@seisman seisman removed the needs review This PR has higher priority and needs review. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure.text sometimes doesn't work if the text contains single/double quotation marks
2 participants