Skip to content

Make all functions/methods have consistent behavior for table output #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 7, 2024

This PR shows how the return_table method added in PR #3083 can simplify the codes.

Wrappers that still use temporary files:

  • info
  • grdinfo
  • which
  • x2sys_cross

@seisman seisman added the run/benchmark Trigger the benchmark workflow in PRs label Mar 7, 2024
Copy link

codspeed-hq bot commented Mar 7, 2024

CodSpeed Performance Report

Merging #3092 will degrade performances by 90.41%

⚠️ No base runs were found

Falling back to comparing table-outputs (466594b) with main (28e3513)

Summary

⚡ 1 improvements
❌ 12 regressions
✅ 85 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main table-outputs Change
test_blockmean_input_xyz 413.4 ms 365.6 ms +13.08%
test_contour_matrix[DataFrame] 90.7 ms 281.8 ms -67.81%
test_contour_matrix[Dataset] 103.9 ms 294.9 ms -64.76%
test_contour_matrix[array] 88.5 ms 279.6 ms -68.34%
test_filter1d_format 199.8 ms 517.8 ms -61.42%
test_grd2xyz 43.1 ms 229.2 ms -81.2%
test_grdtrack_input_dataframe_and_dataarray 44 ms 233.4 ms -81.16%
test_grdvolume_no_outgrid 41.7 ms 294.4 ms -85.82%
test_project_input_matrix[DataFrame] 41.7 ms 422.2 ms -90.13%
test_project_input_matrix[Dataset] 50.8 ms 431.3 ms -88.22%
test_project_input_matrix[array] 40.3 ms 420.9 ms -90.41%
test_select_input_dataframe 187.6 ms 374.3 ms -49.88%
test_delaunay_triples_input_xyz 169.2 ms 357.3 ms -52.65%

@seisman seisman force-pushed the table-outputs branch 3 times, most recently from 24b967a to 5f1a74f Compare March 7, 2024 05:41
Base automatically changed from clib/return_table to main March 11, 2024 11:17
@seisman seisman closed this Mar 14, 2024
@seisman seisman deleted the table-outputs branch March 14, 2024 00:53
@seisman seisman removed the run/benchmark Trigger the benchmark workflow in PRs label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant