Skip to content

Update baseline images for grdimage tests #2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 11, 2024
Merged

Update baseline images for grdimage tests #2984

merged 5 commits into from
Jan 11, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Jan 10, 2024 •
edited
Loading

Address #2961.

All baseline images are re-generated using the equivalent GMT CLI.

test_grdimage

gmt begin map png
    gmt grdimage @earth_relief_01d_g -Cearth -JW0/10c
gmt end

test_grdimage_slice

gmt begin map png
    gmt grdcut @earth_relief_01d_g -R-180/180/-30/30 -Gtmp.nc
    gmt grdimage tmp.nc -Cearth -JM10c
gmt end show

test_grdimage_global_subset

gmt begin map png
gmt grdedit @earth_relief_01d_g -R0/360/-90/90 -Gtmp.nc -fc -D+xx+yy
gmt grdcut tmp.nc -R0/220/-90/30 -Gtmp2.nc
gmt grdimage tmp2.nc -Cvik -Rg -JW0/10c -B
gmt end show

test_grdimage_file

gmt begin map png
gmt grdimage @earth_relief_01d_g -Cocean -R-180/180/-70/70 -JW0/10c -I
gmt end show

@seisman
Update baseline image for test_grdimage
c44b41e 
The baseline image is generated with:
```
gmt begin map png
    gmt grdimage @earth_relief_01d_g -Cearth -JW0/10c
gmt end
```
@seisman seisman changed the title Update baseline images for grdimage tests WIP: Update baseline images for grdimage tests Jan 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_grdimage.png
modified pygmt/tests/baseline/test_grdimage_file.png
modified pygmt/tests/baseline/test_grdimage_global_subset.png
modified pygmt/tests/baseline/test_grdimage_slice.png

Image diff(s)

Added images

Modified images

Path Old New
test_grdimage.png
test_grdimage_file.png
test_grdimage_global_subset.png
test_grdimage_slice.png

Report last updated at commit 531b60a

@seisman seisman changed the title WIP: Update baseline images for grdimage tests Update baseline images for grdimage tests Jan 10, 2024
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jan 10, 2024
@seisman seisman added this to the 0.11.0 milestone Jan 10, 2024
@seisman seisman marked this pull request as ready for review January 10, 2024 11:58
@seisman seisman added the needs review This PR has higher priority and needs review. label Jan 10, 2024
@seisman seisman mentioned this pull request Jan 10, 2024
Closed
14 tasks
@seisman seisman marked this pull request as draft January 10, 2024 12:06
@seisman seisman marked this pull request as ready for review January 10, 2024 12:06
@seisman seisman removed the needs review This PR has higher priority and needs review. label Jan 11, 2024
@seisman seisman merged commit 9e3f0b1 into main Jan 11, 2024
@seisman seisman deleted the baseline/grdimage branch January 11, 2024 02:51
@weiji14 weiji14 mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@seisman @weiji14