Skip to content

Bump the GMT version to 6.5.0 #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Bump the GMT version to 6.5.0 #2966

wants to merge 4 commits into from

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

Address #2961

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@michaelgrund michaelgrund added the maintenance Boring but important stuff for the core devs label Jan 8, 2024
@michaelgrund michaelgrund added this to the 0.11.0 milestone Jan 8, 2024
@michaelgrund michaelgrund mentioned this pull request Jan 8, 2024
14 tasks
@seisman
Copy link
Member

seisman commented Jan 8, 2024

No, we're still going to support GMT 6.3 and 6.4. So, the minimum required version is still 6.3.0.

@michaelgrund
Copy link
Member Author

No, we're still going to support GMT 6.3 and 6.4. So, the minimum required version is still 6.3.0.

You mean in ci_tests_legacy.yaml?

@seisman
Copy link
Member

seisman commented Jan 8, 2024

required_version should be 6.3.0 so that PyGMT works with GMT 6.3, 6.4 and 6.5.

@seisman
Copy link
Member

seisman commented Jan 8, 2024

In other words, none of the changes in this PR make sense, so the PR should be closed.

@michaelgrund
Copy link
Member Author

In other words, none of the changes in this PR make sense, so the PR should be closed.

Then we should remove the corresponding TODOs in #2961

@seisman
Copy link
Member

seisman commented Jan 8, 2024

In other words, none of the changes in this PR make sense, so the PR should be closed.

Then we should remove the corresponding TODOs in #2961

Yes, done.

@seisman seisman deleted the gmt-6.5.0-other branch January 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants