-
Notifications
You must be signed in to change notification settings - Fork 229
Support timedelta64 dtype as input #2884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4730961
Support timedelta64 dtype as input
weiji14 d53138c
Add unit test for plotting timedelta64 data
weiji14 51bc55a
Lint
weiji14 0c20c72
Merge branch 'main' into timedelta64
weiji14 49dbe83
Recreate baseline image using ghostscript 9.54.0
weiji14 d5bedc2
Allow np.timedelta64 inputs to region parameter
weiji14 44e62d6
Fix lint error
weiji14 3aa5e3a
Merge branch 'main' into timedelta64
weiji14 849feda
Revert "Allow np.timedelta64 inputs to region parameter"
weiji14 4c3b8e9
Merge branch 'main' into timedelta64
weiji14 4426d95
Update test_plot_timedelta64 baseline img with GMT 6.5.0 and gs 10.02.1
weiji14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
outs: | ||
- md5: 8edddcec764d244053c4d675e98732b9 | ||
size: 13201 | ||
path: test_plot_timedelta64.png | ||
hash: md5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we could pass in
np.timedelta64
into the region argument as mentioned at #2848 (comment).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, looks like I modified
kwargs_to_strings
3 years ago at #562 to handledatetime
objects inregion
, so could probably do something similar here fortimedelta64
.