Skip to content

Fix the spacing parameter processing for many modules #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2022
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 12, 2022

Description of proposed changes

Similar to #1804, many modules have the -I option, whose alias spacing should support passing a list like spacing=(1.0, 0.5).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the bug Something isn't working label Mar 12, 2022
@seisman seisman added this to the 0.6.0 milestone Mar 12, 2022
@weiji14
Copy link
Member

weiji14 commented Mar 12, 2022

Also for grdproject where spacing is aliased for D, so use D="sequence" instead.

D="spacing",
E="dpi",
F="scaling",
G="outgrid",
J="projection",
I="inverse",
M="unit",
R="region",
V="verbose",
n="interpolation",
r="registration",
)
@kwargs_to_strings(C="sequence", R="sequence")
def grdproject(grid, **kwargs):

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Mar 12, 2022
@seisman seisman merged commit 101a57d into main Mar 13, 2022
@seisman seisman deleted the fix-spacing branch March 13, 2022 05:11
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants