Skip to content

Change test_grdcut.py to use static_earth_relief #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2022

Conversation

willschlitzer
Copy link
Contributor

This modifies test_grdcut.py to use load_static_earth_relief.

Addresses #1684

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 11, 2022
@willschlitzer willschlitzer added this to the 0.6.0 milestone Feb 11, 2022
@willschlitzer willschlitzer self-assigned this Feb 11, 2022
@willschlitzer
Copy link
Contributor Author

Should test_grdcut.py leave in test_grdcut_file_in_file_out() and test_grdcut_file_in_dataarray_out()? As the import for static_earth_relief is already tested in test_helpers.py, it doesn't seem necessary to include it here.

@maxrjones
Copy link
Member

Should test_grdcut.py leave in test_grdcut_file_in_file_out() and test_grdcut_file_in_dataarray_out()? As the import for static_earth_relief is already tested in test_helpers.py, it doesn't seem necessary to include it here.

Either way is fine to me. The GMT API for file input is much stabler than any of the other input types, so these tests seem less important to me.

@maxrjones maxrjones added the final review call This PR requires final review and approval from a second reviewer label Feb 11, 2022
@seisman seisman changed the title Add static_earth_relief to grdcut tests Change test_grdcut.py to use static_earth_relief Feb 12, 2022
@seisman seisman merged commit 1ceb999 into main Feb 12, 2022
@seisman seisman deleted the static-earth-relief/grdcut branch February 12, 2022 15:35
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 12, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants