Skip to content

Update load_earth_relief tests for SRTM15+V2.3 #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2022
Merged

Update load_earth_relief tests for SRTM15+V2.3 #1728

merged 1 commit into from
Feb 8, 2022

Conversation

maxrjones
Copy link
Member

@maxrjones maxrjones commented Feb 7, 2022 •
edited by weiji14
Loading

Description of proposed changes

This PR fixes 3 of the 44 tests that are failing since the update of the @earth_relief remote dataset for SRTM15+V2.3. The remainder of the failing tests are tracked in #1684.

Supersedes #401

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones maxrjones marked this pull request as draft February 7, 2022 23:08
@maxrjones maxrjones marked this pull request as ready for review February 7, 2022 23:09
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 8, 2022
@seisman seisman added this to the 0.6.0 milestone Feb 8, 2022
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Feb 8, 2022
weiji14
weiji14 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Meghan, I'll squash-merge this in now.

@weiji14 weiji14 merged commit b72c8ba into main Feb 8, 2022
@weiji14 weiji14 deleted the update-earth-relief-tests branch February 8, 2022 14:52
@maxrjones maxrjones removed the final review call This PR requires final review and approval from a second reviewer label Feb 8, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Update load_earth_relief tests for SRTM15+V2.3 (GenericMappingTools#1728
1937336 
)

Fixes test failures due to incorrect minimum elevation values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

@weiji14 weiji14 weiji14 approved these changes

@willschlitzer willschlitzer willschlitzer approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maxrjones @seisman @weiji14 @willschlitzer