Fix missing gcmt convention keys in pygmt.meca #1611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the 'rake1' and 'strike2' keys to the global CMT (gcmt) convention, and add a unit test adapted from https://docs.generic-mapping-tools.org/6.2/supplements/seis/meca.html#examples.
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added images
Modified images
Report last updated at commit b59c03a |
seisman
added
the
final review call
|
Ping @tjnewton and @liamtoney for reviews, since they were the main authors of the original PR #516. |
michaelgrund
approved these changes
Nov 7, 2021
weiji14
commented
Nov 7, 2021
| @@ -275,23 +284,21 @@ def update_pointers(data_pointers): | |||
| "plot_latitude": plot_latitude, | |||
| } | |||
|
|
|||
| # make a DataFrame copy to check convention if it contains | |||
| # other parameters | |||
| if isinstance(spec, (dict, pd.DataFrame)): | |||
There was a problem hiding this comment.
Just noticed that this if-statement is unnecessary, because this code block is already nested under an if isinstance(spec, (dict, pd.DataFrame)) statement at L143 above, and there doesn't seem to be any modifications made to the spec variable in between. Please double-check if this looks ok.
weiji14
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
) Adds the 'rake1' and 'strike2' keys to the global CMT (gcmt) convention, and add a unit test adapted from https://docs.generic-mapping-tools.org/6.2/supplements/seis/meca.html#examples. * Remove an unneeded if-statement and pylint disable argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adds the 'rake1' and 'strike2' keys to the global CMT (gcmt) convention, and add a unit test adapted from https://docs.generic-mapping-tools.org/6.2/supplements/seis/meca.html#examples.
Fixes #1580, Patches #516.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version