-
Notifications
You must be signed in to change notification settings - Fork 229
Unset GMT_DATA_SERVER and use the default value #1558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we need to uncache the |
Uncaching the I'm OK with delaying this PR after we bump to GMT 6.3.0. |
Well, I quite like using https (kinda surprised the default is http to be honest). Let's keep the |
Do you think we could use this branch (or open another PR) to see how many tests break in PyGMT with the new SRTM v2.3 earth_relief grids? Specifically, by setting |
The ssl certificate isn't set up, so I don't think https would work yet. I've asked about getting it updated. |
I think it's time to unset the GMT_DATA_SERVER value, so that we know the default server setting works. |
Description of proposed changes
As mentioned in #1556 (comment), the GMT server issue has been fixed. Now it's OK to use the default GMT server URL.
Partially reverts #1553.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version