Skip to content

Unset GMT_DATA_SERVER and use the default value #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 2, 2021

Description of proposed changes

As mentioned in #1556 (comment), the GMT server issue has been fixed. Now it's OK to use the default GMT server URL.

Partially reverts #1553.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 2, 2021
@seisman seisman added this to the 0.5.0 milestone Oct 2, 2021
@weiji14
Copy link
Member

weiji14 commented Oct 3, 2021

Do we need to uncache the @N30W120.earth_relief_15s_p.nc tile? I see that GenericMappingTools/gmt#5829 has been closed in GenericMappingTools/gmt#5834. Otherwise we might forget to uncache that tile when PyGMT bumps to GMT>=6.3.

@seisman
Copy link
Member Author

seisman commented Oct 3, 2021

Uncaching the @N30W120.earth_relief_15s_p.nc tile means that building the documentation will take more time for downloading the tile and may fail on Windows and macOS due to GitHub Action internet connection issues.

I'm OK with delaying this PR after we bump to GMT 6.3.0.

@weiji14
Copy link
Member

weiji14 commented Oct 3, 2021

Uncaching the @N30W120.earth_relief_15s_p.nc tile means that building the documentation will take more time for downloading the tile and may fail on Windows and macOS due to GitHub Action internet connection issues.

I'm OK with delaying this PR after we bump to GMT 6.3.0.

Well, I quite like using https (kinda surprised the default is http to be honest). Let's keep the GMT_DATA_SERVER setting on for a little longer 🙂

@seisman seisman removed this from the 0.5.0 milestone Oct 3, 2021
@seisman seisman marked this pull request as draft October 3, 2021 10:40
@weiji14 weiji14 added this to the 0.6.0 milestone Nov 6, 2021
@weiji14
Copy link
Member

weiji14 commented Nov 6, 2021

Do you think we could use this branch (or open another PR) to see how many tests break in PyGMT with the new SRTM v2.3 earth_relief grids? Specifically, by setting GMT_DATA_SERVER=https://test.generic-mapping-tools.org (xref GenericMappingTools/gmtserver-admin#118) on the macOS workflow for ci_tests_dev.yaml.

@maxrjones
Copy link
Member

Do you think we could use this branch (or open another PR) to see how many tests break in PyGMT with the new SRTM v2.3 earth_relief grids? Specifically, by setting GMT_DATA_SERVER=https://test.generic-mapping-tools.org (xref GenericMappingTools/gmtserver-admin#118) on the macOS workflow for ci_tests_dev.yaml.

The ssl certificate isn't set up, so I don't think https would work yet. I've asked about getting it updated.

@seisman seisman marked this pull request as ready for review February 16, 2022 15:01
@seisman
Copy link
Member Author

seisman commented Feb 16, 2022

I think it's time to unset the GMT_DATA_SERVER value, so that we know the default server setting works.

@maxrjones maxrjones added the final review call This PR requires final review and approval from a second reviewer label Feb 22, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 22, 2022
@seisman seisman merged commit 92a8dea into main Feb 22, 2022
@seisman seisman deleted the unset-data-server branch February 22, 2022 12:42
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants