Skip to content

WIP: Wrap xyz2grd #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

WIP: Wrap xyz2grd #1286

wants to merge 3 commits into from

Conversation

willschlitzer
Copy link
Contributor

This pull request wraps the gmt module xyz2grd.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the feature Brand new feature label May 23, 2021
@willschlitzer willschlitzer added this to the 0.4.0 milestone May 23, 2021
@willschlitzer willschlitzer self-assigned this May 23, 2021
@willschlitzer
Copy link
Contributor Author

I wasn't sure about the etiquette/procedures for taking on another author's pull request (in this case #636), so I opened this PR to wrap xyz2grd.

@weiji14
Copy link
Member

weiji14 commented May 23, 2021

@willschlitzer, I would suggest continuing work on that #636 PR instead of starting a new one here. People (especially newcomers) put a lot of work into making a Pull Request and it is best to give them credit for their original work. There could also be reviews in the orginal PR that we want to keep (though not much in this case).

As a maintainer, you should be able to commit directly to that branch, and I would start with a branch update from master (though maybe ping the original author first to check). C.f. #525 where I continued work on someone's old PR after asking for permission.

@weiji14 weiji14 added the duplicate This issue or pull request already exists label May 23, 2021
@weiji14 weiji14 deleted the wrap-xyz2grd branch October 28, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants