Remove xfails and workarounds for datetime inputs into pygmt.info #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream bug resolved with GMT 6.2.0rc1 so the expected failure (xfail) decorators can be removed now.
weiji14
added
maintenance
seisman
approved these changes
Apr 22, 2021
michaelgrund
pushed a commit
to michaelgrund/pygmt
that referenced
this pull request
Apr 23, 2021
…nericMappingTools#1236) * Remove xfails on pygmt.info tests with a time column Upstream bug resolved with GMT 6.2.0rc1 so the expected failure (xfail) decorators can be removed now. * Remove coltypes="0T" workaround since datetime inputs to pygmt.info is ok now
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…nericMappingTools#1236) * Remove xfails on pygmt.info tests with a time column Upstream bug resolved with GMT 6.2.0rc1 so the expected failure (xfail) decorators can be removed now. * Remove coltypes="0T" workaround since datetime inputs to pygmt.info is ok now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Previously in GMT 6.1.1, UNIX timestamps are returned instead of ISO datetime, and the workaround was to use
coltypes=0T(i.e.-f=0T) inpygmt.info. The upstream bug has been fixed at GenericMappingTools/gmt#4241 and GenericMappingTools/gmt#4849, and is available in GMT 6.2.0rc1, so the workarounds can be removed.Fixes #597
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version